Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle… #11739

Merged
merged 2 commits into from Jun 8, 2020
Merged

[BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle… #11739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c50c03
[BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle…
ibzib May 18, 2020
c482288
Create bounded/unbounded variants of testOutputTimestampDefault.
ibzib Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
View file
Open in desktop
Expand Up @@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
ValidatesRunner.class,
UsesTimersInParDo.class,
UsesUnboundedPCollections.class,
Copy link
Member

@lukecwik lukecwik May 18, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to follow-up with the PR author as to why they added .setIsBoundedInternal(IsBounded.UNBOUNDED) instead and have different variants of runners execute the test (batch/streaming/...).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was so that it would run on a streaming runner (especially the Dataflow runner). ValidatesRunner tests that use TestStream don't run on Dataflow today I believe, and we have several other places in our test codebase where this pattern is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split the test into batch and streaming variants, PTAL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @lukecwik @reuvenlax

DataflowPortabilityApiUnsupported.class
})
public void testOutputTimestampDefault() throws Exception {
Expand Down