[BEAM-10052][BEAM-10077] Cherry-pick PR 11771 to 2.22.0 branch #11843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamikaramj
changed the title
chamikaramj
changed the title
|
Failure is unrelated (seems to be due to Dataflow workers not being available). |
|
Hm so that's what I said for the same failure in #11778, but I actually can't remember why I thought that was the case. @chamikaramj Did you see something in the log indicating it's related to workers? |
|
I think for #11778 I didn't find any explicit evidence that the problem was due to containers, it just seemed likely since the failing tests were all launching Dataflow jobs. |
|
Run Python PreCommit |
|
I think worker logs had a "container not found" error. We can wait for the retry to see if that occurs again. |
|
Looks like PythonDocker succeeded, just wasn't updated here, and python PreCommit is just failing because there are no worker images. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this Dataflow tries to upload the same artifact multiple times which breaks the Dataflow artifact container for some cases.
This change already was merged to HEAD abut a week back [1] but seems like we forgot to add it to the release branch.
[1] #11771
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.