-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10188] Add instructions to programmatically publish release to Github #11918
Conversation
Fixes BEAM-10188
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jphalip! Just a few requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Julien!
Could we add this script to https://github.com/apache/beam/tree/master/release/src/main/scripts? Most of those scripts ask the user for input, for example
beam/release/src/main/scripts/build_release_candidate.sh
Lines 54 to 61 in e1963c1
echo "================Setting Up Environment Variables===========" | |
echo "Which release version are you working on: " | |
read RELEASE | |
RELEASE_BRANCH=release-${RELEASE} | |
echo "Which release candidate number(e.g. 1) are you going to create: " | |
read RC_NUM | |
echo "Please enter your github username(ID): " | |
read USER_GITHUB_ID |
This way, they are self-contained and easy to use.
BTW, if you add the JIRA to the beginning of your PR title, they will be linked automatically.
I didn't realize Brian had already reviewed... and we had almost the exact same comments 😆 |
@ibzib @TheNeuralBit Thank you both for the feedback. I've moved the code to a separate script. All the variables used should already be set in |
That's probably fine, but if that's the expectation we need to |
Ok, I've loaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well. Thanks again @jphalip :)
…Github (apache#11918) * Add instructions to programmatically publish release to Github Fixes BEAM-10188 * Move release notes commands to separate script * Add confirmation message to Github release notes script * Load env vars in Github release notes script * Small tweak to github release notes script
This fixes BEAM-10188.
See discussion in the dev@ list: https://lists.apache.org/thread.html/re367d262333078501c47856e9b8a0fc3fd7db60c2d2ebb181275481a%40%3Cdev.beam.apache.org%3E
This assumes that the blog post starts with "We are happy", which has been the case in most recent posts. But perhaps you'd like to tweak that?