[BEAM-10080] Fixes PipelineOptionsFactoryTest and ReflectHelpersTest for Java 11 #12224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennknowles
force-pushed
the
pipelineoptions-errormsg
branch
from
17f57d0
to
778fa9e
Compare
|
R: @tysonjh |
kennknowles
changed the title
|
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/12263/ is a flake in Spark portable execution. Filed https://issues.apache.org/jira/browse/BEAM-10460. |
|
Run Java PreCommit |
|
https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/2461 was a failure to create a local Cassandra cluster |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Flakes in this run:
|
|
Run Java PreCommit |
|
Looks like https://issues.apache.org/jira/browse/BEAM-8025 in which under load the embedded Cassandra cluster cannot be created. It seems to have come back with the ci-beam Jenkins migration maybe? |
|
Run Java PreCommit |
|
Finally green! |
tysonjh
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the error message checking in
PipeOptionsFactoryTestandReflectHelpersTestto be more robust generally, and also to make it compatible with Java 11.To develop this change #12020 was patched in, but it is not required for merge.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.