[BEAM-10081] Fix ApiSurface to work with Java 11 #12227
Merged
+2
−530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tysonjh |
kennknowles
force-pushed
the
gcp-core-apisurface
branch
from
8beec7a
to
d55621b
Compare
kennknowles
force-pushed
the
gcp-core-apisurface
branch
from
d55621b
to
bd9cdb1
Compare
|
It seems this one annotation is all over the place and removing it from consideration is legitimate. It is added by the platform pervasively. |
kennknowles
force-pushed
the
gcp-core-apisurface
branch
from
bd9cdb1
to
32a6c70
Compare
kennknowles
changed the title
tysonjh
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago when we were on Guava 21.0 there was a bug in
ClassPathbut we could not upgrade Guava so we forkedClassPathfrom Guava'smasterto get the bugfix. Because of that, the reflection underlyingApiSurfacewas not upgraded with our vendored Guava and did not work with Java 11. Un-forkingClasspathmade it work and then adjusting to ignore some new javac-added annotations was simple.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.