[BEAM-10490] Support read/write ZetaSQL DATE/TIME types from/to BigQuery #12261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java PreCommit |
kennknowles
reviewed
Jul 15, 2020
|
Ah, thanks for catching that. Test added. |
|
Run Java PreCommit |
|
Friendly ping |
chamikaramj
reviewed
Jul 17, 2020
| equalTo(new Instant(millis))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSubMilliPrecisionLogicalTypeRejected() { |
There was a problem hiding this comment.
Is this test not relavent anymore ?
There was a problem hiding this comment.
Yes, it's not relavent anymore. ZetaSQL TIME type is now able to support micro-second precision.
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
ettirapp
pushed a commit
to ettirapp/beam
that referenced
this pull request
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix reading BYTES from BigQuery which is also failing currently.
r: @kennknowles @chamikaramj
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.