New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors. #12338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the reason to turn off the rawtype error checks? |
All the modules where it is disabled have rawtype usage, so it must first be fixed before the error can be turned on. |
I should have clarified: after this PR, the default is that rawtypes will break the build. So new modules will not have them. Existing modules have them. |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Run Python2_PVR_Flink PreCommit |
Run Java PreCommit |
run java precommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Run Java PreCommit |
1 similar comment
Run Java PreCommit |
Tried just running precommit locally and publishing a scan. See a timeout (flake?) in Euphoria tests: https://scans.gradle.com/s/gx3exaswuez5w/tests/:sdks:java:extensions:euphoria:test/org.apache.beam.sdk.extensions.euphoria.core.translate.TimestampExtractTransformTest/testTransform#1 |
Run Java PreCommit |
2 similar comments
Run Java PreCommit |
Run Java PreCommit |
Run Portable_Python PreCommit |
Run Python2_PVR_Flink PreCommit |
Ah, finally green, except :sdks:java:io:azure was added and it has rawtype errors and needs disabling. |
Run Java PreCommit |
Noting that this is green and the conflicts in |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.