Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors. #12338

Merged
merged 1 commit into from Jul 25, 2020

Conversation

kennknowles
Copy link
Member


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Copy link
Contributor

@robinyqiu robinyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robinyqiu
Copy link
Contributor

What's the reason to turn off the rawtype error checks?

@kennknowles
Copy link
Member Author

All the modules where it is disabled have rawtype usage, so it must first be fixed before the error can be turned on.

@kennknowles
Copy link
Member Author

I should have clarified: after this PR, the default is that rawtypes will break the build. So new modules will not have them. Existing modules have them.

@kennknowles
Copy link
Member Author

Run Java PreCommit

1 similar comment
@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

Run Python2_PVR_Flink PreCommit

@kennknowles kennknowles changed the title [BEAM-10556] Add flag to ignore rawtype errors and add to modules [BEAM-10556] Make rawtypes an error. Add flag to ignore rawtype errors and add to modules with errors. Jul 22, 2020
@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

run java precommit

@kennknowles
Copy link
Member Author

Run Java PreCommit

1 similar comment
@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

Run Java PreCommit

1 similar comment
@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

@kennknowles
Copy link
Member Author

Run Java PreCommit

2 similar comments
@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

Run Portable_Python PreCommit

@kennknowles
Copy link
Member Author

Run Python2_PVR_Flink PreCommit

@kennknowles
Copy link
Member Author

Ah, finally green, except :sdks:java:io:azure was added and it has rawtype errors and needs disabling.

@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

Noting that this is green and the conflicts in sdks/java/extensions/sketching/build.gradle are just two adjacent edits to the parameters to applyJavaNature. Since this PR is essentially trivial and has been held up by flakes and conflicts, I intend to merge it after resolving the conflict and confirming that compileJava compileTestJava succeeds.

@kennknowles kennknowles merged commit b2c2bff into apache:master Jul 25, 2020
@kennknowles kennknowles deleted the rawtypes branch July 25, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants