Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10580] Eliminate nullability errors from :sdks:java:extensions:sql:expansion-service #12374

Merged
merged 2 commits into from Jul 28, 2020
Merged

Conversation

jayendra13
Copy link
Contributor

…sql:expansion-service
Eliminate nullability errors from :sdks:java:extensions:sql:expansion-service


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@kennknowles kennknowles self-requested a review July 28, 2020 15:51
Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Somehow the other day I thought it was already enabled. I bet this means that fixing rawtypes will catch some new errors, which is good.

@kennknowles kennknowles changed the title [BEAM-10580] Eliminate nullability errors from :sdks:java:extensions:… [BEAM-10580] Eliminate nullability errors from :sdks:java:extensions:sql:expansion-service Jul 28, 2020
@kennknowles
Copy link
Member

It seems there is a merge commit that we don't really need here, so I will squash this PR into master.

@kennknowles kennknowles merged commit 5606867 into apache:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants