[BEAM-10613] Implement BIT_AND for Beam SQL ZetaSQL dialect as CombineFn

[rehmanmuradali]

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	SDK	Dataflow	Flink	Samza	Spark	Twister2
Go		---		---		---
Java
Python				---		---
XLang		---		---		---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

[rehmanmuradali]

R: @reuvenlax @kennknowles

[amaliujia]

@Imfuyuwei

can you provide the NULL test case that failed this implementation before?

[Imfuyuwei]

Yes, one of my previous commit has some tests related to NULL case.

a960772#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434

[amaliujia]

Thanks @Imfuyuwei

Yes, one of my previous commit has some tests related to NULL case.

a960772#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434

@rehmanmuradali can you check this test case and make sure it passes before get this PR merged?

[rehmanmuradali]

Thanks @Imfuyuwei

Yes, one of my previous commit has some tests related to NULL case.
a960772#diff-4f4ffa265fe666e99c37c346d50da67dR428-R434

@rehmanmuradali can you check this test case and make sure it passes before get this PR merged?

@amaliujia the test is failing. Seems like the issue is reported here BEAM-10379

[amaliujia]

Yes. It seems an issue that under the surface. We have to fix that to make bit_and merged.

[rehmanmuradali]

@amaliujia all aggregate functions implementation will be dependent on this ticket? I tried to change the NULL test case(initially bit_and) to bit_or and the issue reproduces.

[amaliujia]

My impression was bit_and crashed due to this special case while others didn't (or not tested). That was why bit_and was disabled.

[kennknowles]

Try this test case: SELECT bit_and(x) FROM (SELECT CAST(NULL AS int64) x);

Expected: NULL
Currently: 9223372036854775807

[stale]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

[stale]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

[shehzaadn-vd]

@ibzib @robinyqiu could you please help us reopen this PR?

cc: @sonam-vend

[stale]

This pull request is no longer marked as stale.

[ibzib]

The nullness issue was fixed and BIT_AND enabled in #15174.