[BEAM-5504] Add Avro support to Pubsub table provider #12780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjotrekk
force-pushed
the
table-provider
branch
from
4db126e
to
0374a98
Compare
pjotrekk
force-pushed
the
table-provider
branch
4 times, most recently
from
3a7bbf7
to
9213387
Compare
|
@TheNeuralBit Could I ask you for review? I wonder whether payloadFormat shouldn't be specified in TBLPROPERTIES instead of creating a separate class for every payload format? I'm planning to write PubsubProtoTableProvider next so there will be another and then probably yet another class. |
pjotrekk
force-pushed
the
table-provider
branch
2 times, most recently
from
7c0fe8d
to
7b14d30
Compare
pjotrekk
changed the title
pjotrekk
force-pushed
the
table-provider
branch
4 times, most recently
from
fa617a4
to
c40eeb2
Compare
|
Yep I can review this!
Yeah I think that's the way to go. Let's add a payloadFormat option in TBLPROPERTIES that defaults to JSON if not specified. |
pjotrekk
force-pushed
the
table-provider
branch
6 times, most recently
from
87141c5
to
ae2fbbc
Compare
4 tasks
pjotrekk
force-pushed
the
table-provider
branch
from
3af8a1c
to
d2933bf
Compare
It's already in TBLPROPERTIES |
pjotrekk
force-pushed
the
table-provider
branch
2 times, most recently
from
4283eca
to
b3a71ef
Compare
|
Run SQL PostCommit |
Done. |
pjotrekk
force-pushed
the
table-provider
branch
from
aecc317
to
66756ff
Compare
|
Run SQL PostCommit |
|
Run Java PreCommit |
TheNeuralBit
requested changes
Oct 27, 2020
.../sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubAvroIT.java
Outdated
Show resolved
Hide resolved
.../io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PayloadFormat.java
Outdated
Show resolved
Hide resolved
...oogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessageToRow.java
Outdated
Show resolved
Hide resolved
|
Run SQL PostCommit |
TheNeuralBit
requested changes
Oct 28, 2020
...test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubTableProviderIT.java
Outdated
Show resolved
Hide resolved
.../sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubAvroIT.java
Outdated
Show resolved
Hide resolved
...oogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessageToRow.java
Outdated
Show resolved
Hide resolved
...oogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/RowToPubsubMessage.java
Outdated
Show resolved
Hide resolved
website/www/site/content/en/documentation/dsls/sql/extensions/create-external-table.md
Show resolved
Hide resolved
pjotrekk
force-pushed
the
table-provider
branch
from
77da35a
to
e3efcb4
Compare
added 13 commits
October 29, 2020 10:42
pjotrekk
force-pushed
the
table-provider
branch
from
e3efcb4
to
582ef45
Compare
|
Run SQL PostCommit |
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pubsub avro table provider.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.