[BEAM-10556] Move rawtype error suppression to class level #13261
Conversation
kennknowles
force-pushed
the
rawtypes-classlevel
branch
from
f96eb9f
to
ac7e5a8
Compare
|
R: @tysonjh I saw you fix a rawtype in your pull request and it reminded me. I was very happy with the result of doing this with nullness checks. |
| @@ -22,7 +22,7 @@ plugins { id 'org.apache.beam.module' } | |||
| applyJavaNature( | |||
| automaticModuleName: 'org.apache.beam.runners.dataflow', | |||
| enableChecker: false, | |||
| ignoreRawtypeErrors: true) | |||
| ) | |||
There was a problem hiding this comment.
Ideally, spotless would reformat this, but I guess it doesn't.
| @@ -121,7 +121,9 @@ | |||
| * <p>The example will try to cancel the pipelines on the signal to terminate the process (CTRL-C) | |||
| * and then exits. | |||
| */ | |||
| @SuppressWarnings("nullness") // TODO(https://issues.apache.org/jira/browse/BEAM-10402) | |||
| @SuppressWarnings({ | |||
| "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402) | |||
There was a problem hiding this comment.
There are a number of changes like this that I did just to make it more sane to automatically add the rawtype warnings. I can revert if you like or separate into another commit.
There was a problem hiding this comment.
SG. It's a mechanical change so no problem leaving it in this commit.
| @@ -121,7 +121,9 @@ | |||
| * <p>The example will try to cancel the pipelines on the signal to terminate the process (CTRL-C) | |||
| * and then exits. | |||
| */ | |||
| @SuppressWarnings("nullness") // TODO(https://issues.apache.org/jira/browse/BEAM-10402) | |||
| @SuppressWarnings({ | |||
| "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402) | |||
There was a problem hiding this comment.
SG. It's a mechanical change so no problem leaving it in this commit.
|
Ooh |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Looks like GitHub Actions one job failed to upload logs after the tests passed. Is there a way to rerun just that action? |
There should be an option in the workflow list, I can't see it but always assumed it was because I'm not a committer: |
|
I only have "Re-run all jobs" which seems like overkill. Perhaps it is just about how the actions are grouped. |
Previously rawtype errors were suppressed at the module level. This makes it more fine-grained so it is easier to fix a class and have it stay fixed.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.