[BEAM-11074] build_release_candidate usability improvements. #13290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this change checks whether a tag exists before calling the gradle release plugin, allowing the user to either delete the existing tag or skip creating the tag. Also avoids going into interactive commit messages with SVN, instead using commit messages built-in to the script.
|
R: @ibzib @kennknowles Kenn, adding you as a reviewer because one of my changes basically reverts a change you made in an old commit. I found it slightly user unfriendly because one moment the script is just running and then suddenly you're thrown into an interactive commit prompt without much context about what to do. Going back to having the script prompting seems more user-friendly, and also means that the script can automatically set a commit message. |
ibzib
reviewed
Nov 10, 2020
| echo "Delete the tag and create a new tag commit (y) or skip this step (n)? [y/N]" | ||
| read confirmation | ||
| if [[ $confirmation = "y" ]]; then | ||
| git push origin :refs/tags/v${RELEASE}-RC${RC_NUM} |
There was a problem hiding this comment.
Can you add a comment explaining how this deletes the tag?
| git push origin :refs/tags/v${RELEASE}-RC${RC_NUM} | ||
| fi | ||
| fi | ||
| if [[ $confirmation = "y" ]]; then # Expected to only be "n" if user chose to skip creating tag. |
There was a problem hiding this comment.
Suggested change
| if [[ $confirmation = "y" ]]; then # Expected to only be "n" if user chose to skip creating tag. | |
| if [[ $confirmation = "y" ]]; then # Expected to be "y" unless user chose to skip creating tag. |
|
Run Java PreCommit |
lostluck
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this change checks whether a tag exists before calling the gradle release plugin, allowing the user to either delete the existing tag or skip creating the tag. Also avoids going into interactive commit messages with SVN, instead using commit messages built-in to the script.
Note that the original intention behind this change is to allow finer-grained skipping in the release candidate script to avoid problems if steps need to be repeated if a release candidate fails. For example, in the current implementation if a release candidate fails after creating a release candidate tag and that step gets run again, it'll cause an error due to trying to create an existing tag. I tried to read through the script to find other instances where repeating a step might be problematic, but I couldn't really find anything else that isn't already skippable. Reviewers, let me know if I missed any.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.