New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10961] Make plugins' transitive dependencies compileOnly dependencies. #13690
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13690 +/- ##
==========================================
- Coverage 82.76% 82.74% -0.02%
==========================================
Files 466 466
Lines 57520 57525 +5
==========================================
- Hits 47605 47600 -5
- Misses 9915 9925 +10
Continue to review full report at Codecov.
|
Run Java_Examples_Dataflow PreCommit |
Run Python PreCommit |
2 similar comments
Run Python PreCommit |
Run Python PreCommit |
Run PythonDocs PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
R: @kennknowles |
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
Run Java_Examples_Dataflow PreCommit |
1 similar comment
Run Java_Examples_Dataflow PreCommit |
Run Python PreCommit |
Run Java PreCommit |
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
Run Java_Examples_Dataflow PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great. One general comment: since the order of dependency lists doesn't matter to the computer, please keep them alphabetized where possible. It makes them easier to read for humans. (This also applies to all of the other PRs in this series.)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.