Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10961] Make plugins' transitive dependencies compileOnly dependencies. #13690

Merged
merged 9 commits into from Jan 14, 2021

Conversation

sonam-vend
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #13690 (52f831a) into master (6c9da02) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13690      +/-   ##
==========================================
- Coverage   82.76%   82.74%   -0.02%     
==========================================
  Files         466      466              
  Lines       57520    57525       +5     
==========================================
- Hits        47605    47600       -5     
- Misses       9915     9925      +10     
Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.63% <0.00%> (-4.55%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.90% <0.00%> (-1.82%) ⬇️
sdks/python/apache_beam/io/source_test_utils.py 88.28% <0.00%> (-1.36%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.29% <0.00%> (-0.53%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.44% <0.00%> (-0.26%) ⬇️
sdks/python/apache_beam/dataframe/frames.py 91.88% <0.00%> (-0.11%) ⬇️
...apache_beam/portability/api/beam_runner_api_pb2.py 100.00% <0.00%> (ø)
sdks/python/apache_beam/transforms/util.py 95.84% <0.00%> (+0.17%) ⬆️
sdks/python/apache_beam/transforms/external.py 72.09% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9da02...52f831a. Read the comment docs.

@sonam-vend sonam-vend marked this pull request as draft January 8, 2021 12:03
@sonam-vend
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@sonam-vend
Copy link
Contributor Author

Run Python PreCommit

2 similar comments
@sonam-vend
Copy link
Contributor Author

Run Python PreCommit

@sonam-vend
Copy link
Contributor Author

Run Python PreCommit

@sonam-vend
Copy link
Contributor Author

Run PythonDocs PreCommit

@sonam-vend sonam-vend marked this pull request as ready for review January 11, 2021 08:21
Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibzib ibzib changed the title Feature/strict dependency [BEAM-10961] Make plugins' transitive dependencies compileOnly dependencies. Jan 11, 2021
@ibzib
Copy link
Contributor

ibzib commented Jan 11, 2021

R: @kennknowles

@sonam-vend
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

1 similar comment
@sonam-vend
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

@sonam-vend
Copy link
Contributor Author

Run Python PreCommit

@sonam-vend
Copy link
Contributor Author

Run Java PreCommit

@sonam-vend
Copy link
Contributor Author

Run Java_Examples_Dataflow PreCommit

Copy link
Contributor

@ibzib ibzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great. One general comment: since the order of dependency lists doesn't matter to the computer, please keep them alphabetized where possible. It makes them easier to read for humans. (This also applies to all of the other PRs in this series.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants