[BEAM-10402] Add nullability annotations to SplitResult.of #13769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyuanzz
reviewed
Jan 21, 2021
| @@ -28,7 +28,7 @@ | |||
| public abstract class SplitResult<RestrictionT> { | |||
| /** Returns a {@link SplitResult} for the specified primary and residual restrictions. */ | |||
| public static <RestrictionT> SplitResult<RestrictionT> of( | |||
| RestrictionT primary, RestrictionT residual) { | |||
| @Nullable RestrictionT primary, @Nullable RestrictionT residual) { | |||
There was a problem hiding this comment.
Would the @Nullabe annotations below(L36 and L39) be enough?
There was a problem hiding this comment.
Actually no, because the call SplitRestriction.of(null, ...) is reported as bug by tools such as SonarCloud. That is due to implicit @Nonnull added by the checkerframework.
There was a problem hiding this comment.
I see. Thanks for the explanation!
boyuanzz
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nullable annotations to SplitResult.of (primary and residual can be null).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.