New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-11804] Remove vendors/sdk-java-extensions-protobuf #13968
Conversation
R: @kennknowles |
Run Flink ValidatesRunner |
Codecov Report
@@ Coverage Diff @@
## master #13968 +/- ##
==========================================
+ Coverage 82.86% 82.89% +0.03%
==========================================
Files 466 466
Lines 57599 57728 +129
==========================================
+ Hits 47730 47856 +126
- Misses 9869 9872 +3
Continue to review full report at Codecov.
|
Run Java PreCommit |
Run Flink ValidatesRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. The class is basically trivial and it really isn't worth the complexity of the dependency and relocation that we do.
I should note my motivation here: the previous solution causes problems with This was blocking #13963 |
Run Java PreCommit |
That's a good motivation, in addition to just simplifying. Thanks for noticing and doing this! It is probably a bit of an esoteric area of the project for most people to wade into. |
Instead duplicate ByteStringCoder with vendored protobuf in runners/java-fn-execution
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.