Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11804] Remove vendors/sdk-java-extensions-protobuf #13968

Merged
merged 1 commit into from Feb 12, 2021

Conversation

TheNeuralBit
Copy link
Member

Instead duplicate ByteStringCoder with vendored protobuf in runners/java-fn-execution

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

R: @kennknowles
CC: @dpcollins-google I think this will unblock #13963

@TheNeuralBit
Copy link
Member Author

Run Flink ValidatesRunner

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #13968 (31d5667) into master (b3fd2bd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13968      +/-   ##
==========================================
+ Coverage   82.86%   82.89%   +0.03%     
==========================================
  Files         466      466              
  Lines       57599    57728     +129     
==========================================
+ Hits        47730    47856     +126     
- Misses       9869     9872       +3     
Impacted Files Coverage Δ
sdks/python/apache_beam/dataframe/frames.py 91.07% <100.00%> (ø)
sdks/python/apache_beam/internal/metrics/metric.py 86.45% <0.00%> (-1.05%) ⬇️
sdks/python/apache_beam/io/localfilesystem.py 91.66% <0.00%> (-0.76%) ⬇️
sdks/python/apache_beam/dataframe/expressions.py 91.02% <0.00%> (-0.14%) ⬇️
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.19% <0.00%> (-0.09%) ⬇️
.../runners/portability/fn_api_runner/translations.py 92.10% <0.00%> (-0.08%) ⬇️
...beam/testing/load_tests/load_test_metrics_utils.py 34.96% <0.00%> (-0.02%) ⬇️
...apache_beam/runners/portability/portable_runner.py 76.30% <0.00%> (ø)
...eam/runners/portability/fn_api_runner/fn_runner.py 89.87% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1a034...31d5667. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

Run Java PreCommit

@TheNeuralBit
Copy link
Member Author

Run Flink ValidatesRunner

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. The class is basically trivial and it really isn't worth the complexity of the dependency and relocation that we do.

@TheNeuralBit
Copy link
Member Author

I should note my motivation here: the previous solution causes problems with @AutoService usages in :sdks:java:extensions:protobuf, because it ends up creating two different META-INF/service files for the same implementation.

This was blocking #13963

@TheNeuralBit
Copy link
Member Author

Run Java PreCommit

@TheNeuralBit TheNeuralBit merged commit dcf3e78 into apache:master Feb 12, 2021
@kennknowles
Copy link
Member

That's a good motivation, in addition to just simplifying. Thanks for noticing and doing this! It is probably a bit of an esoteric area of the project for most people to wade into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants