Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11659] Add new schema types to Pub/Sub SQL #13980

Merged
merged 12 commits into from Mar 17, 2021

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Feb 12, 2021

Add pubsub handling of byte array payload schemas and ARRAY<ROW<VARCHAR key, VARCHAR value>> attributes schemas.

These enable pure-sql lossless copies to and from Pub/Sub Lite and kafka.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@dpcollins-google
Copy link
Contributor Author

R: @amaliujia

@amaliujia
Copy link
Contributor

cc @robinyqiu @TheNeuralBit

@TheNeuralBit TheNeuralBit self-requested a review March 4, 2021 17:55
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thank you. A couple more minor requests:

I'll run some internal tests to double-check everything

@TheNeuralBit
Copy link
Member

Run SQL PostCommit

@dpcollins-google
Copy link
Contributor Author

Add test(s) in PubsubTableProviderIT for the new configurations

Done

@dpcollins-google
Copy link
Contributor Author

dpcollins-google commented Mar 6, 2021

Update https://beam.apache.org/documentation/dsls/sql/extensions/create-external-table/#pubsub for the new

I'm going to bulk update this once the other two PRs are merged.

@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

@TheNeuralBit
Copy link
Member

Thanks! It looks like the new tests aren't passing though. I think one issue is using BYTES instead of VARBINARY, the other is less clear. Maybe because value isn't allowed to be an identifier? You might try wrapping it in backticks or changing the name.

@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

2 similar comments
@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

1 similar comment
@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

@kennknowles kennknowles changed the title [BEAM-11659] Add new schema types to Pub/Sub SQL [BEAM-11659][BEAM-11963] Add new schema types to Pub/Sub SQL Mar 12, 2021
@TheNeuralBit
Copy link
Member

Run SQL PostCommit

@dpcollins-google
Copy link
Contributor Author

Run SQL PostCommit

@dpcollins-google
Copy link
Contributor Author

Run Java PreCommit

1 similar comment
@TheNeuralBit
Copy link
Member

Run Java PreCommit

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Ran internal tests and they look good.

I can merge when CI is green

@TheNeuralBit TheNeuralBit changed the title [BEAM-11659][BEAM-11963] Add new schema types to Pub/Sub SQL [BEAM-11659] Add new schema types to Pub/Sub SQL Mar 17, 2021
@TheNeuralBit TheNeuralBit merged commit 4565a31 into apache:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants