[BEAM-10961] enable strict dependency checking for flink/job-server #14115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shehzaadn-vd
commented
Feb 27, 2021
| @@ -78,6 +79,7 @@ configurations.all { | |||
|
|
|||
| dependencies { | |||
| compile project(flinkRunnerProject) | |||
| permitUnusedDeclared project(flinkRunnerProject) // BEAM-11761 | |||
There was a problem hiding this comment.
Without this line, analyzeDependencies products an unusedDeclared error for all runners/flink//job-server/. We could have removed the compile line, but we can't until BEAM-11761 remains open.
|
Run Java Flink PortableValidatesRunner Batch |
|
Run Flink ValidatesRunner |
|
Run Python Flink ValidatesRunner |
|
Run Java Flink PortableValidatesRunner Streaming |
|
@ibzib I think this is running into BEAM-11887 which is yet to be fixed... |
Thanks for looking it up. Since the test is new, I am not worried about it failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13658 intended to enable strict dependency checking for everything under runners/flink, but it missed runners/flink/job-server.
It also seems to have introduced unnecessary changes to runners/flink//job-server/build.gradle files
This PR enables strict dependency checking for runners/flink/job-server (which effectively covers runners/flink/[version]/job-server/).
R: @ibzib
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.