Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-10961] enable strict dependency checking for flink/job-server #14115

Merged
merged 2 commits into from
Mar 1, 2021
Merged

[BEAM-10961] enable strict dependency checking for flink/job-server #14115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979a3bf
[BEAM-10961] enable strict dependency checking for flink/job-server
shehzaadn-vd Feb 27, 2021
3eea80d
[BEAM-10761] add reference to BEAM-11761
shehzaadn-vd Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions runners/flink/1.10/job-server/build.gradle
View file
Open in desktop
Expand Up @@ -29,7 +29,3 @@ project.ext {

// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"

dependencies {
runtimeOnly project(":runners:flink:1.10")
}
4 changes: 0 additions & 4 deletions runners/flink/1.11/job-server/build.gradle
View file
Open in desktop
Expand Up @@ -29,7 +29,3 @@ project.ext {

// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"

dependencies {
runtimeOnly project(":runners:flink:1.11")
}
4 changes: 0 additions & 4 deletions runners/flink/1.12/job-server/build.gradle
View file
Open in desktop
Expand Up @@ -29,7 +29,3 @@ project.ext {

// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"

dependencies {
runtimeOnly project(":runners:flink:1.12")
}
4 changes: 0 additions & 4 deletions runners/flink/1.8/job-server/build.gradle
View file
Open in desktop
Expand Up @@ -29,7 +29,3 @@ project.ext {

// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"

dependencies {
runtimeOnly project(":runners:flink:1.8")
}
4 changes: 0 additions & 4 deletions runners/flink/1.9/job-server/build.gradle
View file
Open in desktop
Expand Up @@ -29,7 +29,3 @@ project.ext {

// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"

dependencies {
runtimeOnly project(":runners:flink:1.9")
}
2 changes: 2 additions & 0 deletions runners/flink/job-server/flink_job_server.gradle
View file
Open in desktop
Expand Up @@ -30,6 +30,7 @@ apply plugin: 'application'
mainClassName = "org.apache.beam.runners.flink.FlinkJobServerDriver"

applyJavaNature(
enableStrictDependencies: true,
automaticModuleName: 'org.apache.beam.runners.flink.jobserver',
archivesBaseName: project.hasProperty('archives_base_name') ? archives_base_name : archivesBaseName,
validateShadowJar: false,
Expand Down Expand Up @@ -78,6 +79,7 @@ configurations.all {

dependencies {
compile project(flinkRunnerProject)
permitUnusedDeclared project(flinkRunnerProject) // BEAM-11761
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this line, analyzeDependencies products an unusedDeclared error for all runners/flink//job-server/. We could have removed the compile line, but we can't until BEAM-11761 remains open.

runtime group: "org.slf4j", name: "jcl-over-slf4j", version: dependencies.create(project.library.java.slf4j_api).getVersion()
validatesPortableRunner project(path: flinkRunnerProject, configuration: "testRuntime")
validatesPortableRunner project(path: ":sdks:java:core", configuration: "shadowTest")
Expand Down