Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1251] Use Python 3 semantics in Cython-compiled modules. #14198

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

tvalentyn
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@tvalentyn
Copy link
Contributor Author

Run Dataflow Python 3.7 PostCommit

@tvalentyn
Copy link
Contributor Author

Run Python 3.7 PostCommit

@tvalentyn
Copy link
Contributor Author

Run Python 3.8 PostCommit

@tvalentyn
Copy link
Contributor Author

Run Python 3.6 PostCommit

@tvalentyn
Copy link
Contributor Author

Run Python 3.7 PostCommit

@tvalentyn
Copy link
Contributor Author

Run Dataflow Python ValidatesRunner

@tvalentyn
Copy link
Contributor Author

Run PYthon Dataflow ValidatesRunner

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #14198 (27f713d) into master (e3367a1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14198      +/-   ##
==========================================
- Coverage   83.15%   83.14%   -0.01%     
==========================================
  Files         469      469              
  Lines       58946    58924      -22     
==========================================
- Hits        49016    48995      -21     
+ Misses       9930     9929       -1     
Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/data_plane.py
...s/sdks/python/apache_beam/io/gcp/tests/__init__.py
...y38/build/srcs/sdks/python/apache_beam/io/kafka.py
...beam/runners/interactive/display/pipeline_graph.py
...py38/build/srcs/sdks/python/apache_beam/io/jdbc.py
...ild/srcs/sdks/python/apache_beam/transforms/sql.py
...ython/apache_beam/io/gcp/datastore/v1new/helper.py
...on/apache_beam/runners/dataflow/dataflow_runner.py
...beam/runners/portability/local_job_service_main.py
...am/testing/benchmarks/nexmark/models/field_name.py
... and 928 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f9f66...27f713d. Read the comment docs.

@tvalentyn
Copy link
Contributor Author

R: @lazylynx

@lazylynx
Copy link
Contributor

LGTM, thanks @tvalentyn

@tvalentyn tvalentyn merged commit b0a33da into apache:master Mar 12, 2021
@tvalentyn tvalentyn deleted the cython_py3 branch March 12, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants