-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-5949] Remove trivial __ne__ implementations. #13887
Conversation
R: @lazylynx |
@tvalentyn Are |
I left other ne as is since they had a different implementation, the one in pipeline_test can proabably go as well. |
Understood, LGTM! |
I think we need to verify that Beam's cythonization is using Py3 semantic before merging this or similar changes, otherwise the behavior in cythonized codepath could change. For example there are directives in some files:
but we may not have them in other files. I don't know if there is a way to make it a default when we invoke Cython or build wheels for all files without upgrading to Cython 3 when this becomes default. CC: @robertwb who may have advice. I'll have to park this change for a bit. |
Let's just put |
sg, put together #14198; running some suites & internal performance tests on it just in case. |
Run Python_PVR_Flink PreCommit |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.