Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5949] Remove trivial __ne__ implementations. #13887

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

tvalentyn
Copy link
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #13887 (5e0c21b) into master (4ff08fe) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13887      +/-   ##
==========================================
+ Coverage   83.35%   83.37%   +0.02%     
==========================================
  Files         468      468              
  Lines       58800    58689     -111     
==========================================
- Hits        49012    48934      -78     
+ Misses       9788     9755      -33     
Impacted Files Coverage Δ
...build/srcs/sdks/python/apache_beam/io/snowflake.py
...hon/apache_beam/runners/worker/bundle_processor.py
...cs/sdks/python/apache_beam/portability/__init__.py
...ache_beam/examples/cookbook/datastore_wordcount.py
...thon/apache_beam/runners/worker/channel_factory.py
...ache_beam/runners/dataflow/test_dataflow_runner.py
...cs/sdks/python/apache_beam/transforms/combiners.py
.../srcs/sdks/python/apache_beam/utils/annotations.py
.../apache_beam/options/pipeline_options_validator.py
...am/portability/api/standard_window_fns_pb2_urns.py
... and 926 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff08fe...5e0c21b. Read the comment docs.

@tvalentyn
Copy link
Contributor Author

R: @lazylynx

@lazylynx
Copy link
Contributor

@tvalentyn Are __ne__ in window.py L232 and pipeline_test.py L804 also needed to be remove?

@tvalentyn
Copy link
Contributor Author

I left other ne as is since they had a different implementation, the one in pipeline_test can proabably go as well.

@lazylynx
Copy link
Contributor

Understood, LGTM!

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Feb 24, 2021

I think we need to verify that Beam's cythonization is using Py3 semantic before merging this or similar changes, otherwise the behavior in cythonized codepath could change.

For example there are directives in some files:

# cython: language_level=3

but we may not have them in other files. I don't know if there is a way to make it a default when we invoke Cython or build wheels for all files without upgrading to Cython 3 when this becomes default. CC: @robertwb who may have advice.

I'll have to park this change for a bit.

@robertwb
Copy link
Contributor

Let's just put # cython: language_level=3 in all our compiled files for now. There's few of them, we could just touch the non-compiled files with this PR if we want.

@tvalentyn
Copy link
Contributor Author

sg, put together #14198; running some suites & internal performance tests on it just in case.

@tvalentyn tvalentyn marked this pull request as ready for review March 17, 2021 03:02
@tvalentyn
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@tvalentyn tvalentyn merged commit e67ba2b into apache:master Mar 18, 2021
@tvalentyn tvalentyn deleted the beam-5949 branch March 18, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants