Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-11797] Fix wrong assertion usage #14377

Merged
merged 1 commit into from
Mar 30, 2021
Merged

[BEAM-11797] Fix wrong assertion usage #14377

merged 1 commit into from
Mar 30, 2021

Commits on Mar 30, 2021

  1. [BEAM-11797] Fix wrong assertion usage 

    1. Replaced all assert_called_with with assert_any_call in the
   ProgressIndicatorTest.
2. assert_called_with only asserts the most recent call. However, there
   is an IPythonLogHandler we have customized to emit rich logging in
   notebooks that also calls display to render HTML and JavaScript. The
   emission of logs can happen any time during the test, causing the
   flakiness. Instead of unregistering the log handler during tests that
   could make the tests unnecessarily complicated, we could use
   assert_any_call within the patched context for simplicity.
    KevinGG committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    492dcba View commit details
    Browse the repository at this point in the history