[BEAM-11213] Display Beam Metrics in Spark History Server for Classic Runner #14409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iemejia
force-pushed
the
BEAM-11212-spark-metrics-display
branch
from
8059182
to
26ee103
Compare
iemejia
changed the title
iemejia
commented
Apr 2, 2021
| @@ -34,18 +34,6 @@ | |||
| */ | |||
| public interface SparkPipelineOptions extends SparkCommonPipelineOptions { | |||
|
|
|||
| @Description("Set it to true if event logs should be saved to Spark History Server directory") | |||
There was a problem hiding this comment.
Historically we avoid if possible to introduce variables that are already defined as Spark Configurations, so these variables should come from the Spark configuration to avoid duplicated non synchronized configuration changes and confusion for end users.
iemejia
commented
Apr 2, 2021
| final JavaSparkContext jsc, SparkPipelineOptions pipelineOptions, long startTime) { | ||
| EventLoggingListener eventLoggingListener = null; | ||
| try { | ||
| if (jsc.getConf().getBoolean("spark.eventLog.enabled", false)) { |
There was a problem hiding this comment.
This is the official Spark way to configure what the eventLogEnabled and sparkHistoryDir options were doing. So better to use these.
… Runner too It also removes the SparkPipelineOptions related to events logging because those are already configured and used by Spark config.
iemejia
force-pushed
the
BEAM-11212-spark-metrics-display
branch
from
26ee103
to
9e0b378
Compare
|
Run Spark ValidatesRunner |
|
Run Spark ValidatesRunner Java 11 |
|
Run Java Spark PortableValidatesRunner Batch |
ibzib
approved these changes
Apr 2, 2021
| @@ -34,18 +34,6 @@ | |||
| */ | |||
| public interface SparkPipelineOptions extends SparkCommonPipelineOptions { | |||
|
|
|||
| @Description("Set it to true if event logs should be saved to Spark History Server directory") | |||
| @@ -97,7 +102,7 @@ | |||
| private static final Logger LOG = LoggerFactory.getLogger(SparkRunner.class); | |||
|
|
|||
| /** Options used in this pipeline runner. */ | |||
| private final SparkPipelineOptions mOptions; | |||
| private final SparkPipelineOptions pipelineOptions; | |||
| metricsPusher.start(); | ||
|
|
||
| if (eventLoggingListener != null && jsc != null) { |
There was a problem hiding this comment.
I'm curious how jsc could be null here?
There was a problem hiding this comment.
It can't it would have definitely failed before but I am double checking just to be sure.
|
Thanks @ibzib ! |
iemejia
changed the title
iemejia
added a commit
to iemejia/beam
that referenced
this pull request
Apr 2, 2021
… Metrics in Spark History Server for Classic Runner It also removes the SparkPipelineOptions related to events logging because those are already configured and used by Spark config.
kennknowles
added a commit
that referenced
this pull request
Apr 7, 2021
… 2.29.0: Display Beam Metrics in Spark History Server for Classic Runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @ibzib
CC: @tszerszen (for awareness)