[BEAM-12145] Normalize and size-limit transform Ids #14500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java PostCommit |
chamikaramj
force-pushed
the
normalize_java_transform_id
branch
from
3d29f9e
to
31ffe77
Compare
kennknowles
reviewed
Apr 9, 2021
| @@ -191,6 +193,10 @@ private String getApplicationName(AppliedPTransform<?, ?, ?> appliedPTransform) | |||
| if (name.isEmpty()) { | |||
| name = "unnamed-ptransform"; | |||
| } | |||
| // Normalize, trim, and uniqify. | |||
| int maxNameLength = 100; | |||
| name = Normalizer.normalize(name, Form.NFC).replaceAll("[^A-Za-z0-9-_]", "-"); | |||
There was a problem hiding this comment.
Let's document the required regex in the pipeline proto. Is there validation logic like there is in Python? That would be a good place to check it, too.
There was a problem hiding this comment.
Added a comment to the proto recommending alphanumeric characters, '_', and '-' for transform IDs.
Also added a test.
Corresponding Python changes are in #14502.
kennknowles
approved these changes
Apr 9, 2021
chamikaramj
force-pushed
the
normalize_java_transform_id
branch
from
31ffe77
to
f693052
Compare
chamikaramj
force-pushed
the
normalize_java_transform_id
branch
2 times, most recently
from
2d0b60c
to
bee1a14
Compare
|
Run Python PreCommit |
|
Run Java_Examples_Dataflow PreCommit |
|
Run Java PostCommit |
chamikaramj
force-pushed
the
normalize_java_transform_id
branch
from
bee1a14
to
30afbcb
Compare
|
Run Java PostCommit |
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform IDs generated by the SDK may be used by runners to identify pipeline steps hence its preferable to keep them normalized, size limited, and unique.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.