[BEAM-12174] Samza Portable Runner Support #14554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Samza runner to work with 1. Portable Runner 2. JobServerDriver 3. DefaultJobBundleFactory in portability framework
xinyuiscool
reviewed
Apr 16, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaJobInvoker.java
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaJobInvoker.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 19, 2021 15:52
mynameborat
reviewed
Apr 20, 2021
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaExecutionContext.java
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaJobInvoker.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/beam/runners/samza/runtime/SamzaExecutableStageContextFactory.java
Outdated
Show resolved
Hide resolved
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/DoFnOp.java
Show resolved
Hide resolved
|
Is there already a test suite for the portable samza runner? |
Good question. There isn't any test enabled for portable samza runner at the moment, it is actually one of the goals for us when revamp the Samza runner to support portability. |
added 2 commits
April 20, 2021 15:21
|
Looks good to me. @xinyuiscool can you merge it after it passes the build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Samza runner with :
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.