[BEAM-12442] Make sure that row renames work properly in nested rows. #14960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @mouyang |
|
Run Java PreCommit |
TheNeuralBit
approved these changes
Jun 9, 2021
| Schema expectedSchema = | ||
| Schema.builder() | ||
| .addStringField("top1") | ||
| .addRowField("top_nested", expectedNestedSchema) |
There was a problem hiding this comment.
optional super nitty nit: I think this would be easier to grok if the nested schemas were defined inline.
| } | ||
| })) | ||
| .setRowSchema(outputSchema); | ||
| } | ||
| } | ||
|
|
||
| // TODO(reuvenlax): For better performance, we should reuse functionality in |
| default: | ||
| return inputType; | ||
| } | ||
| } | ||
|
|
||
| // Apply the user-specified renames to the input schema. | ||
| private static Schema renameSchema(Schema inputSchema, Collection<RenamePair> renames) { | ||
| @VisibleForTesting |
There was a problem hiding this comment.
Why not just test through the public interface, rather than exposing renameSchema and renameRows?
There was a problem hiding this comment.
I'm not sure how. The problem with the public interface is that it uses the DirectRunner, and the characteristic of this bug is that the DirectRunner tends to obscure the bug by serializing/deserializing.
@reuvenlax LGTM. I have two general knowledge questions.
|
|
@mouyang correct on both counts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.