Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9547] Add implementations for some lesser-used pandas operations #15108

Merged
merged 7 commits into from
Jul 8, 2021

Conversation

TheNeuralBit
Copy link
Member

@TheNeuralBit TheNeuralBit commented Jun 30, 2021

This PR adds support for a few lesser-used operations that are easy to implement.

Some elementwise operations:

  • at_time
  • between_time
  • Series.explode (this was already implemented in DataFrame)
  • subtract, divide (aliases for sub, div)

Some aggregation functions:

  • sem (standard error of the mean)
  • mad (mean absolute deviation)
  • skew
  • kurt/kurtosis

Note all of these aggregation functions are implemented as unliftable aggregations here, but I think they can all be parallelized. skew and kurtosis can take a similar appraoch to std/var (filed BEAM-12550 for this). sem and mad will require more research to find a distributed algorithm (if one exists).

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit TheNeuralBit changed the title [BEAM-9547] Add implementations for some lesser-used operations [BEAM-9547] Add implementations for some lesser-used pandas operations Jun 30, 2021
@TheNeuralBit
Copy link
Member Author

R: @robertwb

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #15108 (43dcc2f) into master (b86fcf9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15108      +/-   ##
==========================================
+ Coverage   83.78%   83.83%   +0.05%     
==========================================
  Files         439      441       +2     
  Lines       59245    59744     +499     
==========================================
+ Hits        49638    50087     +449     
- Misses       9607     9657      +50     
Impacted Files Coverage Δ
sdks/python/apache_beam/dataframe/frames.py 94.72% <100.00%> (+0.07%) ⬆️
sdks/python/apache_beam/io/kafka.py 74.28% <0.00%> (-4.89%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.07% <0.00%> (-0.18%) ⬇️
setup.py 0.00% <0.00%> (ø)
...ython/apache_beam/examples/kafkataxi/kafka_taxi.py 0.00% <0.00%> (ø)
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py 69.76% <0.00%> (ø)
...ks/python/apache_beam/ml/gcp/recommendations_ai.py 87.26% <0.00%> (ø)
...hon/apache_beam/runners/worker/bundle_processor.py 93.85% <0.00%> (+0.12%) ⬆️
.../apache_beam/runners/direct/transform_evaluator.py 90.44% <0.00%> (+0.65%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.86% <0.00%> (+1.38%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86fcf9...43dcc2f. Read the comment docs.

@TheNeuralBit
Copy link
Member Author

retest this please

@robertwb robertwb merged commit 085bc2b into apache:master Jul 8, 2021
calvinleungyk pushed a commit to calvinleungyk/beam that referenced this pull request Jul 13, 2021
apache#15108)

* Elementwise aggregations
* Support remaining unliftable aggregations
* Add agg method aliases
* Add aliases for arithmetic operators
calvinleungyk pushed a commit to calvinleungyk/beam that referenced this pull request Sep 22, 2021
apache#15108)

* Elementwise aggregations
* Support remaining unliftable aggregations
* Add agg method aliases
* Add aliases for arithmetic operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants