Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12710] Disable TestStreamTest.testFirstElementLate for portable FlinkRunner #15262

Merged
merged 1 commit into from Aug 17, 2021

Conversation

je-ik
Copy link
Contributor

@je-ik je-ik commented Aug 2, 2021

Fixes [BEAM-12710]. I'm not sure if this should be considered a permanent fix, but I'd say that yes - the test will probably never function properly on Flink.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@je-ik je-ik requested a review from kennknowles August 2, 2021 14:07
@je-ik
Copy link
Contributor Author

je-ik commented Aug 2, 2021

Run Java Flink PortableValidatesRunner Streaming

@je-ik
Copy link
Contributor Author

je-ik commented Aug 15, 2021

@kennknowles Would you have a sec to review this?

@je-ik
Copy link
Contributor Author

je-ik commented Aug 17, 2021

R: @lukecwik

@lukecwik
Copy link
Member

This mirrors the already disabled test in non-portable

excludeTestsMatching 'org.apache.beam.sdk.testing.TestStreamTest.testFirstElementLate'
so it makes sense to disable here.

@lukecwik lukecwik merged commit 2ab0024 into apache:master Aug 17, 2021
@je-ik je-ik deleted the BEAM-12710 branch August 17, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants