Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-10917][BEAM-12810] Reverting PR-15185 #15402

Merged
merged 4 commits into from Aug 27, 2021

Conversation

vachan-shetty
Copy link
Contributor

Reverting #15185


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@vachan-shetty
Copy link
Contributor Author

R: @chamikaramj @kmjung

@vachan-shetty
Copy link
Contributor Author

Run PythonLint PreCommit

@vachan-shetty vachan-shetty changed the title Reverting PR-15185 [BEAM-12810] Reverting PR-15185 Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #15402 (2e78dae) into master (7611831) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15402      +/-   ##
==========================================
+ Coverage   83.66%   83.78%   +0.11%     
==========================================
  Files         440      440              
  Lines       59950    59847     -103     
==========================================
- Hits        50158    50143      -15     
+ Misses       9792     9704      -88     
Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 75.53% <100.00%> (+7.91%) ⬆️
sdks/python/apache_beam/transforms/combiners.py 93.71% <100.00%> (+0.11%) ⬆️
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py 56.81% <0.00%> (-12.95%) ⬇️
sdks/python/apache_beam/internal/metrics/metric.py 90.42% <0.00%> (-1.07%) ⬇️
sdks/python/apache_beam/io/gcp/bigquery_tools.py 86.67% <0.00%> (-0.74%) ⬇️
sdks/python/apache_beam/dataframe/frames.py 94.87% <0.00%> (-0.07%) ⬇️
setup.py 0.00% <0.00%> (ø)
...ks/python/apache_beam/coders/coders_test_common.py 98.51% <0.00%> (+0.01%) ⬆️
sdks/python/apache_beam/io/iobase.py 86.21% <0.00%> (+0.06%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d0dcb...2e78dae. Read the comment docs.

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

Please also cherry-pick the fix to the 2.33.0 release branch.

@chamikaramj chamikaramj merged commit 92b9977 into apache:master Aug 27, 2021
vachan-shetty added a commit to vachan-shetty/beam that referenced this pull request Aug 27, 2021
@kennknowles
Copy link
Member

BEAM-12180 description is "Revert #15185 on 2.33.0 release branch" but this PR is tagged with it even though it is reverting it on the master branch.

@chamikaramj chamikaramj changed the title [BEAM-12810] Reverting PR-15185 [BEAM-10917] Reverting PR-15185 Aug 30, 2021
@chamikaramj
Copy link
Contributor

This was using the wrong Jira. Updated.

@chamikaramj chamikaramj changed the title [BEAM-10917] Reverting PR-15185 [BEAM-10917][BEAM-12810] Reverting PR-15185 Aug 30, 2021
@vachan-shetty vachan-shetty deleted the revert-pr branch September 2, 2021 14:03
vachan-shetty added a commit to vachan-shetty/beam that referenced this pull request Sep 2, 2021
calvinleungyk pushed a commit to calvinleungyk/beam that referenced this pull request Sep 22, 2021
* Reverting PR-15185

* Lint fixes.

* Formatting fixes.

* More formatting fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants