Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13872] [Playground] Increase test coverage for the code_processing package #16891

Merged
merged 6 commits into from Mar 3, 2022

Conversation

pavel-avilov
Copy link
Contributor

@pavel-avilov pavel-avilov commented Feb 18, 2022

[BEAM-13872]
Add unit tests to increase test coverage for the code_processing package


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pavel-avilov
Copy link
Contributor Author

@ilya-kozyrev @KhaninArtur

@@ -695,7 +714,7 @@ func Benchmark_ProcessPython(b *testing.B) {
}
b.StartTimer()

Process(ctx, cacheService, lc, pipelineId, appEnv, sdkEnv, "")
Process(ctx, cacheService, lc, pipelineId, appEnv, sdkEnv, "--output t.txt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move it to constant as well as it's done with others)

cancelChannel: make(chan bool, 1),
createExecFile: true,
},
code: "package main\nimport \"fmt\"\nfunc main() {\n fmt.Println(\"hello world\")\n}\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to extract code variables with useful names

cancelChannel: make(chan bool, 1),
createExecFile: false,
},
code: "class HelloWorld {\n public static void main(String[] args) {\n System.out.println(\"Hello world!\");\n }\n}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor

@KhaninArtur KhaninArtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same thing with naming of tests as mentioned in this PR – #16826

@@ -948,11 +967,17 @@ func Test_runStep(t *testing.T) {
if err != nil {
panic(err)
}
sdkEnv, err := environment.ConfigureBeamEnvs(appEnvs.WorkingDir())
sdkJavaEnv, err := environment.ConfigureBeamEnvs(appEnvs.WorkingDir())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add test cases with Go SDK (unit tests and examples) that contain errors? Our tests don't cover these cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see that we don't have test cases for the compileStep() method:

  • case with Python SDK/SCIO SDK or Go SDK unit tests -> cache should contain status Status_STATUS_EXECUTING and empty CompileOutput, RunOutput, RunError, Logs, Graph
  • case when reconcileBackgroundTask() method returns err (expired context for example) -> cache should contain the same status like it was before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepareStep() method:

  • test case with an error during builder.Preparer() -> cache should contain status Status_STATUS_ERROR
  • case when reconcileBackgroundTask() method returns err (expired context for example) -> cache should contain the same status like it was before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validateStep() method:

  • test case with an error during builder.Preparer() -> cache should contain status Status_STATUS_ERROR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processSetupError() method:

  • test case with an error during utils.SetToCache() -> return err

GetLastIndex() method:

  • test case with an error during converging value to float64 -> return err

readGraphFile() method:

  • test case with reading an existed graph file -> cache should contain Graph
  • test case with ctx.Done() and exists graph file -> cache should contain Graph

processErrorWithSavingOutput method:

  • test case with an error during utils.SetToCache method (maybe use redis-mock) -> return err

processRunError method:

  • ditto

processCompileSuccess method:

  • tests cases with an error during utils.SetToCache() for each subkeys (CompileOutput/RunOutput/RunError/Logs/Graph/Status) (maybe use redis-mock) -> return err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@KhaninArtur KhaninArtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just one small question

args args
}{
{
name: "All success",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a negative test case here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't have

if err != nil {
panic(err)
}
filePath := filepath.Join("configs", pb.Sdk_SDK_JAVA.String()+".json")
filePath := filepath.Join(configFolder, pb.Sdk_SDK_JAVA.String()+".json")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

".json" -> constant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// As a result status into cache should be set as Status_STATUS_PREPARATION_ERROR.
name: "Prepare step failed",
createExecFile: true,
code: "package main\nimport \"fmt\"\nfunc main() {\n fmt.Println(\"hello world\").\n}\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code -> constant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a variable, not to constant

}{
{
name: "Test compilation step working without an error",
name: "Test compilation step working on java sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working -> finishes successfully

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

expectedStatus: pb.Status_STATUS_EXECUTING,
},
{
name: "Test compilation step working on python sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}{
{
name: "Test run step working without an error",
name: "Test run step working on python sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added commentaries

expectedStatus: pb.Status_STATUS_RUN_ERROR,
},
{
name: "Test run step working on go sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added commentaries

expectedStatus: pb.Status_STATUS_RUN_ERROR,
},
{
name: "Test run step without preparing files with code",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

success or fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fail, expected to get Status_STATUS_RUN_ERROR pipeline status

args args
}{
{
name: "All success",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have more descriptive name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@AydarZaynutdinov AydarZaynutdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Just small suggestions.

if err != nil {
panic(err)
}
filePath := filepath.Join("configs", pb.Sdk_SDK_JAVA.String()+".json")
filePath := filepath.Join(configFolder, pb.Sdk_SDK_JAVA.String()+jsonExtension)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
filePath := filepath.Join(configFolder, pb.Sdk_SDK_JAVA.String()+jsonExtension)
filePath := filepath.Join(configFolder, fmt.Sprintf("%s%s", pb.Sdk_SDK_JAVA.String(), jsonExtension))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

err := os.MkdirAll(configFolder, fs.ModePerm)
if err != nil {
panic(err)
}
filePath := filepath.Join(configFolder, sdk.String()+".json")
filePath := filepath.Join(configFolder, sdk.String()+jsonExtension)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
filePath := filepath.Join(configFolder, sdk.String()+jsonExtension)
filePath := filepath.Join(configFolder, fmt.Sprintf("%s%s", pb.Sdk_SDK_JAVA.String(), jsonExtension))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@daria-malkova daria-malkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +1525 to +1532
name: "Successfully saving the prepared graph to the cache",
args: args{
pipelineLifeCycleCtx: pipelineLifeCycleCtx,
backgroundCtx: context.Background(),
cacheService: cacheService,
graphFilePath: graphFilePath,
pipelineId: uuid.New(),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when we don't have the file with a graph? Does any error raise?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we can have this case as a negative one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no errors raised. If we don't have a graph file, we'll just skip saving it to the cache.

Copy link
Contributor

@KhaninArtur KhaninArtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-avilov
Copy link
Contributor Author

R: @pabloem

@pabloem
Copy link
Member

pabloem commented Mar 3, 2022

LGTM

@pabloem pabloem merged commit d6b7144 into apache:master Mar 3, 2022
nancyxu123 pushed a commit to nancyxu123/beam that referenced this pull request Mar 10, 2022
…se test coverage for the code_processing package

* Increase test coverage for the code_processing package

* Refactoring code

* Add test cases with mock cache

* Add test for processCompileSuccess method

* Update test names

* Refactoring code
pabloem added a commit that referenced this pull request Mar 18, 2022
…r transaction boundaries and transaction ID ordering.

* Added integration test for transaction boundaries and transaction ID ordering. Made small fixes in ordered by key integration test.

* [BEAM-9150] Fix beam_PostRelease_Python_Candidate (python RC validation scripts) (#16955)

* Use default context output rather than outputWithTimestamp for ElasticsearchIO

* Palo Alto case study - fix link

* [BEAM-12777] Removed current docs version redirect

* Merge pull request #16850: [BEAM-11205] Upgrade Libraries BOM dependencies to 24.3.0

* Update GCP Libraries BOM version to 24.3.0

* Update associated dependencies

* Merge pull request #16484 from [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

* Implement method to get a default example for each SDKs

* Add error handling

* Added saving of precompiled objects catalog to cache at the server startup

* Added caching of the catalog only in case of unspecified SDK

* Update regarding comments

* Update regarding comments

* Simplified logging regarding comment

* Get defaultExamplePath from the corresponding config

* Refactoring code

* Add the `link` field to response

* Remove gjson;
Resolve conflicts;

* Refactoring code

* Getting default precompiled object from cache

* Refactoring code

* Added saving of precompiled objects catalog to cache at the server startup

* Added caching of the catalog only in case of unspecified SDK

* Update regarding comments

* Update regarding comments

* Simplified logging regarding comment

* Updates regarding comments

* Update for environment_service_test.go

* Get default example from catalog

* GetCatalogFromCacheOrStorage method

* Update licenses

* Update licenses;
Resolve conflicts;

* [BEAM-13633][Playground]
Change saving default precompiled objects to the cache

* [BEAM-13633][Playground]
Change logic of saving and receiving info about default precompiled objects

* [BEAM-13633][Playground]
Separate for each sdk

* [BEAM-13633][Playground]
regenerate proto files

* Add code of the default example to response

* Revert "Add code of the default example to response"

This reverts commit da6baa0.

* Refactoring code

* Refactoring code;
Add test;

* Edit commentaries

* Refactoring code

* Add bucket name to methods

Co-authored-by: Artur Khanin <artur.khanin@akvelon.com>
Co-authored-by: AydarZaynutdinov <aydar.zaynutdinov@akvelon.com>
Co-authored-by: Pavel Avilov <pavel.avilov>

* Add 2022 events blog post (#16975)

* Clean up Go formatter suggestions (#16973)

* [BEAM-14012] Add go fmt to Github Actions (#16978)

* [BEAM-13911] Add basic tests to Go direct runner. (#16979)

* [BEAM-13960] Add support for more types when converting from between row and proto (#16875)

* Adding schema support.

* Addressing feedback.

* Bump org.mongodb:mongo-java-driver to 3.12.10

* [BEAM-13973] Link Dataproc Flink master URLs to the InteractiveRunner when FlinkRunner is used (#16904)

* [BEAM-13925] Turn pr bot on for go prs (#16984)

* [BEAM-13964] Bump kotlin to 1.6.x (#16882)

* [BEAM-13964] Bump kotlin to 1.6.x

* [BEAM-13964] Bump kotlin to 1.6.x

* [BEAM-13964] fix warnings in Kotlin compilation

* Skipping flaky sad-path tests for Spanner changestreams

* Merge pull request #16906: [BEAM-13974] Handle idle Storage Api streams

* Merge pull request #16562 from [BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

* [BEAM-13051] Pylint no-name-in-module and no-value-for-parameter warnings enabled

* [BEAM-13051] Fixed no-value-for-parameter warning for missing default values

* [BEAM-13051] Fixed parameters warnings

* [BEAM-13925] A couple small pr-bot bug fixes (#16996)

* [BEAM-14029] Add getter, setter for target maven repo (#16995)

* [BEAM-13903] Improve coverage of metricsx package (#16994)

* [BEAM-13892] Improve coverage of avroio package (#16990)

* [adhoc] Prepare aws2 ClientConfiguration for json serialization and cleanup AWS Module (#16894)

* [adhoc] Prepare aws2 ClientConfiguration and related classes for json serialization and cleanup AWS Module

* Merge pull request #16879 from [BEAM-12164] Add javadocs to SpannerConfig

* Add tests and config for retry

* lint

* add tests

* lint

* Delete tests not passing

* Rebase on apache beam master

* review changes

* review changes

* add javadocs to SpannerConfig

* revert

* add full stops

* [Cleanup] Update pre-v2 go package references (#17002)

* [BEAM-13885] Add unit tests to window package (#16971)

* Merge pull request #16891 from [BEAM-13872] [Playground] Increase test coverage for the code_processing package

* Increase test coverage for the code_processing package

* Refactoring code

* Add test cases with mock cache

* Add test for processCompileSuccess method

* Update test names

* Refactoring code

* Merge pull request #16912 from [BEAM-13878] [Playground] Increase test coverage for the fs_tool package

* Increase test coverage for the fs_tool package

* Rename folder

* Remove useless variable

* Update test names

* Merge pull request #16946 from [BEAM-13873] [Playground] Increase test coverage for the environment package

* Increase test coverage for the environment package

* Update test names

* Refactoring code

* Add bucket name to method

* [BEAM-13999] playground - support vertical orientation for graph

* [BEAM-13951] Update mass_comment.py list of Run commands (#16889)

* BEAM-13951: Sort run command list

* BEAM-13951: Update list

* fixup! BEAM-13951: Update list

* [BEAM-10652] Allow Clustering without Partition in BigQuery (#16578)

* [BEAM-10652] removed check that blocked clustering without partitioning

* [BEAM-10652] allow clustering without requiring partition

* newline

* added needed null

* remove testClusteringThrowsWithoutPartitioning

* update clustering

* formatting

* now compiles

* passes spotless

* update doc

* focus on single test

* spotless

* run all ITs

* spotless

* testing with time partitioning

* checking

* set clustering independant of partitioning

* remove timepart from it

* spotless

* removed test

* added TODO

* removed block of unneded code/comment

* remove override to v3 coder

* Spotless cleanup

* re-add override to v3 coder

* spotless

* adding checksum ( wrong value )

* added needed query var

* use tableName as var

* DATASET NAME

* project name in query

* update query

* change tests

* remove unneeded imports

* remove rest of forgotten

* add rows

* 16000 bytes

* bigint

* streaming test

* spotless

* methods

* end stream

* stream method and naming

* nostream

* streaming

* streamingoptions

* without streaming example

* string column instead of date -- related to BEAM-13753

* mor strings

* spotless

* revert, only DEFAULT and FILE_LOADS

* [BEAM-13857] Add K:V flags for expansion service jars and addresses to Go ITs. (#16908)

Adds functionality for running jars to the Go integration test framework, and uses this functionality to implement handling of K:V flags for providing expansion service jars and addresses to the test framework. This means that tests can simply get the address of an expansion service with the appropriate label, and this feature will handle running a jar if necessary, or just using the passed in endpoint otherwise.

* BEAM-14011 fix s3 filesystem multipart copy

* Merge pull request #16842 from [BEAM-13932][Playground] Container's user privileges

* [BEAM-13932][Playground]
Change Dockerfiles

* [BEAM-13932][Playground]
Update proxy and permissions for the container's user

* [BEAM-13932][Playground]
Update permissions for the container's user for scio

* Doc updates and blog post for 2.37.0 (#16887)

* Doc updates and blog post for 2.37.0

* Add BEAM-13980 to known issues

* Update dates

* Drop known issue (fix cherrypicked)

* Add license

* Add missing #

* Remove resolved issue in docs + update class path on sample (#17018)

* [BEAM-14016] Fixed flaky postcommit test (#17009)

Fixed SpannerWriteIntegrationTest.test_spanner_update by fixing the
metric exporter usage in spannerio.

* [BEAM-13925] months in date constructor are 0 indexed

* [BEAM-13947] Add split() and rsplit(), non-deferred column operations on categorical columns (#16677)

* Add split/rsplit; Need to refactor regex

* Support Regex; Refactor tests

* Remove debugger

* fix grammar

* Fix passing regex arg

* Reorder imports

* Address PR comments; Simplify kwargs

* Simplify getting columns for split_cat

* Update doctests to skip expand=True operations

* Fix missing doctest

* py: Import beam plugins before starting SdkHarness

* BEAM-14026 - Fixes bug related to Unnesting nested rows in an array (#16988)

* Suggested changes to handle nested row in an array

* Beam-14026 Suggested changes to handle nested row in an array

* Beam-14026 Enhanced by segregating the code from getBaseValues enhanced test case and example.

* Beam-14026 The code is moved from Row to avoid impact to the public interface.
The code is moved to BeamUnnestRel.java since its the caller class.
The Example code was duplicate, hence dropped.
build.gradle updated with the removal of example code.

* Remove resolved issue in notebook

* Bump numpy bound to include 1.22 and regenerate container deps.

* [BEAM-13925] Add ability to get metrics on pr-bot performance (#16985)

* Add script to get metrics on pr-bot performance

* Respond to feedback

* fix bad condition

* [BEAM-11085] Test that windows are correctly observed in DoFns

* Give pr bot write permissions on pr update

* Adding a logical type for Schemas using proto serialization. (#16940)

* BEAM-13765 missing PAssert methods (#16668)

* [BEAM-13909] improve coverage of Provision package (#17014)

* improve coverage of provision package

* updated comments

* [BEAM-14050] Update taxi.go example instructions

* Merge pull request #17027: [BEAM-11205] Upgrade GCP Libraries BOM dependencies to 24.4.0

* [BEAM-13709] Inconsistent behavior when parsing boolean flags across different APIs in Python SDK (#16929)

* Update dataflow API client.

* Instructions for updating apitools generated files.

* [BEAM-10976] Bundle finalization: Harness and some exec changes (#16980)

* Bundle finalization harness side changes

* Add testing

* Iterate over pardos directly

* Track bundlefinalizer in plan.go not pardo

* Remove outdated test

* Fix pointer issue

* Update todos to reference jiras

* Cleanup from feedback

* Doc nit

Co-authored-by: Daniel Oliveira <younghoono@gmail.com>

* GetExpirationTime comment

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Daniel Oliveira <younghoono@gmail.com>

* Merge pull request #16976 from [BEAM-14010] [Website] Add Playground section to the Home page

* [BEAM-14010] [Website] Add Playground section to the Home page

* Update button to "Try Playground"

Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

* [BEAM-14010] [Website] change button name

* [BEAM-14010] [Website] align header to center

* [BEAM-14010] [Website] change link

Co-authored-by: Alex Kosolapov <alex.kosolapov@akvelon.com>
Co-authored-by: Aydar Zainutdinov <aydar.zaynutdinov@akvelon.com>

* [BEAM-12447] Upgrade cloud build client and add/cleanup options (#17032)

* Merge pull request #17036 from [BEAM-12164] Convert all static instances to be transient in the connector in order to enable concurrent testing

* Convert all static instances to be transient in the connector in order to enable concurrent testing

* Initialized fields to null

* nullness

* Suppress uninitialized warnings

* Remove resetting dao factory fields in SpannerChangeStreamErrorTest.java

* Add validation package

* fix variable reference (#16991)

* Committed changes

* Print more logging

* More logging

* Made pipelines streaming

* Made small fixes

* Small fixes

* Ran spotless Apply

Co-authored-by: emily <emilyye@google.com>
Co-authored-by: egalpin <egalpin@users.noreply.github.com>
Co-authored-by: Aydar Farrakhov <stranniknm@gmail.com>
Co-authored-by: Miguel Hernandez <rogelio.hernandez@wizeline.com>
Co-authored-by: Benjamin Gonzalez <74670721+benWize@users.noreply.github.com>
Co-authored-by: Pavel Avilov <avilovpavel6@gmail.com>
Co-authored-by: Artur Khanin <artur.khanin@akvelon.com>
Co-authored-by: AydarZaynutdinov <aydar.zaynutdinov@akvelon.com>
Co-authored-by: Ahmet Altay <aaltay@gmail.com>
Co-authored-by: Jack McCluskey <34928439+jrmccluskey@users.noreply.github.com>
Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
Co-authored-by: laraschmidt <laraschmidt@users.noreply.github.com>
Co-authored-by: Alexey Romanenko <aromanenko.dev@gmail.com>
Co-authored-by: Victor <career@victorplusc.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: Masato Nakamura <randomstep@gmail.com>
Co-authored-by: Pablo Estrada <pabloem@apache.org>
Co-authored-by: reuvenlax <relax@google.com>
Co-authored-by: Miguel Hernandez <61989986+roger-mike@users.noreply.github.com>
Co-authored-by: Moritz Mack <mmack@talend.com>
Co-authored-by: Zoe <zoc@google.com>
Co-authored-by: Brian Hulette <bhulette@google.com>
Co-authored-by: brucearctor <5032356+brucearctor@users.noreply.github.com>
Co-authored-by: Daniel Oliveira <daniel.o.programmer@gmail.com>
Co-authored-by: sp029619 <stephen.patel@cerner.com>
Co-authored-by: David Cavazos <dcavazos@google.com>
Co-authored-by: Ning Kang <ningkang0957@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Andy Ye <andyye333@gmail.com>
Co-authored-by: Rahul Iyer <rahuliyer573@gmail.com>
Co-authored-by: abhijeet-lele <56114083+abhijeet-lele@users.noreply.github.com>
Co-authored-by: Valentyn Tymofieiev <valentyn@google.com>
Co-authored-by: Marcin Kuthan <marcin.kuthan@gmail.com>
Co-authored-by: Ritesh Ghorse <riteshghorse@gmail.com>
Co-authored-by: Jack McCluskey <jrmccluskey@google.com>
Co-authored-by: ansh0l <ansh0l@users.noreply.github.com>
Co-authored-by: Anand Inguva <34158215+AnandInguva@users.noreply.github.com>
Co-authored-by: Robert Bradshaw <robertwb@gmail.com>
Co-authored-by: Daniel Oliveira <younghoono@gmail.com>
Co-authored-by: bullet03 <bulat.safiullin@akvelon.com>
Co-authored-by: Alex Kosolapov <alex.kosolapov@akvelon.com>
Co-authored-by: Yichi Zhang <zyichi@google.com>
Co-authored-by: Nancy Xu <nancyxu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants