[BEAM-14116] Catch MonitoringInfoMetricName null keys or values in the constructor #17094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lukecwik |
|
R: @scwhittle |
scwhittle
reviewed
Mar 16, 2022
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
|
Run Java PreCommit |
dpcollins-google
changed the title
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
lukecwik
requested changes
Mar 17, 2022
...oogle-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
Outdated
Show resolved
Hide resolved
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
...s/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
Outdated
Show resolved
Hide resolved
|
CC: @robertwb |
lukecwik
approved these changes
Mar 21, 2022
| } | ||
| return urn.split(":", 2)[0]; | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() { | ||
| if (labels.containsKey(MonitoringInfoConstants.Labels.NAME)) { |
There was a problem hiding this comment.
nit: ditto on not looking in the map multiple times
|
Run Java PreCommit |
|
Run Java_Examples_Dataflow_Java11 PreCommit |
|
Run Portable_Python PreCommit |
lukecwik
approved these changes
Mar 22, 2022
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Manually kicked off Java PreCommit for this PR https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/21736 because the github comments aren't making it to Jenkins |
|
Run Java PreCommit |
|
Java PreCommit finally passed |
|
@youngoli It looks like this change uncovered additional cases. We thought we caught the cases where this was happening but additional integration testing within Google caught that this fails for Datastore as well. Filed https://issues.apache.org/jira/browse/BEAM-14179 |
youngoli
added a commit
to youngoli/beam
that referenced
this pull request
Mar 31, 2022
…es in the constructor (apache#17094)" This reverts commit 836f82e.
Merged
4 tasks
nielm
added a commit
to nielm/beam
that referenced
this pull request
May 4, 2022
…ecution PR apache#16547 added handling for null ProjectIDs on command line execution, but did not handle the possibility of null ProjectIDs in template execution. PR apache#17094 added nullness checks in MonitoringInfoMetricNames, which then triggered NPEs if the ProjectID was not specified during a template execution.
nielm
added a commit
to nielm/beam
that referenced
this pull request
May 4, 2022
…ecution PR apache#16547 added handling for null ProjectIDs on command line execution, but did not handle the possibility of null ProjectIDs in template execution. PR apache#17094 added nullness checks in MonitoringInfoMetricNames, which then triggered NPEs if the ProjectID was not specified during a template execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix possibly null field