-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-12164]: fix the autoscaling backlog estimation for Spanner Change Streams Connector #17200
Conversation
...in/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/beam/sdk/io/gcp/spanner/changestreams/dofn/ReadChangeStreamPartitionDoFn.java
Show resolved
Hide resolved
...ava/org/apache/beam/sdk/io/gcp/spanner/changestreams/dofn/ReadChangeStreamPartitionDoFn.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimator.java
Outdated
Show resolved
Hide resolved
...va/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimatorTest.java
Show resolved
Hide resolved
.../src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/util/TimestampGenerator.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimator.java
Show resolved
Hide resolved
d9031fe
to
06fd55c
Compare
Codecov Report
@@ Coverage Diff @@
## master #17200 +/- ##
==========================================
+ Coverage 73.94% 73.97% +0.02%
==========================================
Files 684 672 -12
Lines 89519 88460 -1059
==========================================
- Hits 66194 65437 -757
+ Misses 22165 21902 -263
+ Partials 1160 1121 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
06fd55c
to
3c952c4
Compare
Run Java_Examples_Dataflow PreCommit |
68fa94e
to
fd1e90a
Compare
...ava/org/apache/beam/sdk/io/gcp/spanner/changestreams/dofn/ReadChangeStreamPartitionDoFn.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimator.java
Show resolved
Hide resolved
...c/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/TimestampUtils.java
Outdated
Show resolved
Hide resolved
...va/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimatorTest.java
Outdated
Show resolved
Hide resolved
194eea9
to
a55cb4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...va/org/apache/beam/sdk/io/gcp/spanner/changestreams/restriction/ThroughputEstimatorTest.java
Outdated
Show resolved
Hide resolved
17a2d10
to
2afbc65
Compare
Run Java PreCommit |
taking a look at this... |
dc2cbcc
to
96362e2
Compare
Run Java PostCommit |
5b03701
to
8c990db
Compare
Run Java PreCommit |
Run Java PostCommit |
this LGTM. Thanks y'all! |
No description provided.