[BEAM-14310] [Website] bug home playground #17444
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
R: @nausharipov |
| // License for the specific language governing permissions and limitations under | ||
| // the License. | ||
|
|
||
| $('#playgroundIframeContainer').on('click', function(event) { |
There was a problem hiding this comment.
'event' is declared but its value is never read.
There was a problem hiding this comment.
@bullet03 I think it's better to use underscore for unused params:
$('#playgroundIframeContainer').on('click', function(_) {
| // WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| // License for the specific language governing permissions and limitations under | ||
| // the License. | ||
|
|
There was a problem hiding this comment.
To avoid future confusion, I suggest to give a more specific name to the file (something like "fix-playground-nested-scroll.js") and add a comment that describes its purpose.
Example of a comment:
"This script fixes the issue of a sudden scroll interruption when a user's cursor hovered over the embedded playground"
There was a problem hiding this comment.
got it. gonna fix in future commits.
| allow="clipboard-write"> | ||
| </iframe> | ||
| <div id="playgroundIframeContainer"> | ||
| <iframe |
There was a problem hiding this comment.
Let's format this file. Do it in a separate commit in case other reviewers ask us to revert the change.
There was a problem hiding this comment.
was told to make less commits. before that i made a new one on each logical step.
There was a problem hiding this comment.
@bullet03 in this case it would make sense to commit the formatted code separately
|
@pcoet this is a fix for scrolling issue - the scrolling was "stuck" when on Playground section, can you please review? :) |
|
@pabloem this PR was reviewed by David, can you please help us merge? :) |
|
thanks! |
…playground * [BEAM-14310] [Website] fix scroll bug on iframe * [BEAM-14310] [Website] fix playground iframe scroll bug * [BEAM-14310] [Website] delete unused params in fix-playground.js * [BEAM-14310] [Website] changed name of fix-playground, added param with underscore
[BEAM-14310]
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.