Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14311] [Website] Home Page Improvements - Margins & Width #17388

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

bullet03
Copy link
Contributor

[BEAM-14311]

  • change width of h1 and h2 in header section
  • change space (margin and padding) between sections

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Apr 19, 2022

Can one of the admins verify this patch?

3 similar comments
@asf-ci
Copy link

asf-ci commented Apr 19, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 19, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Apr 19, 2022

Can one of the admins verify this patch?

@bullet03
Copy link
Contributor Author

R: @AydarZaynutdinov

@dariabezkorovaina
Copy link
Contributor

@bullet03 got some feedback, please reduce the whitespace between sections even more (for How Does It Work section: ~ margin-top: 20px, margin-bottom: 30px) and the rest of the sections should have the same margins, too.

Copy link
Contributor

@nausharipov nausharipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dariabezkorovaina
Copy link
Contributor

@pcoet can you please approve these minor changes, too?
Reduced whitespaces and adjusted header section as per Aizhamal's request.

@dariabezkorovaina
Copy link
Contributor

@pabloem and this PR #17388 is to be merged AFTER #17444 is merged (#17444 should be merged first), please help with this one, too, if you can:)

@pabloem
Copy link
Member

pabloem commented Apr 28, 2022

lgtm thanks!

@pabloem pabloem merged commit 8bbdb7a into apache:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants