Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5878] Add (failing) kwonly-argument test #17509

Merged
merged 1 commit into from
May 6, 2022

Conversation

TheNeuralBit
Copy link
Member

DoFnSignature and MethodWrapper don't properly handle kwonly arguments (some TODO(BEAM-5878) references in the codebase point to the paths that need to be updated).

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit
Copy link
Member Author

R: @lazylynx @tvalentyn

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #17509 (6d398dc) into master (b3c99b0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17509   +/-   ##
=======================================
  Coverage   73.85%   73.85%           
=======================================
  Files         690      690           
  Lines       90843    90843           
=======================================
+ Hits        67093    67095    +2     
+ Misses      22537    22535    -2     
  Partials     1213     1213           
Flag Coverage Δ
python 83.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.90% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 93.08% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c99b0...6d398dc. Read the comment docs.

@TheNeuralBit TheNeuralBit merged commit 8d3b4bb into apache:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants