Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14436] Adds code reviewers for GCP I/O connectors and KafkaIO to Beam OWNERS files #17581

Merged
merged 1 commit into from
May 8, 2022

Conversation

chamikaramj
Copy link
Contributor

@chamikaramj chamikaramj commented May 6, 2022

Also updates the connector code to suggest using these reviewers for any significant changes to these connectors.

This will help reduce future regressions related to these connectors.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@chamikaramj
Copy link
Contributor Author

R: @aaltay

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #17581 (88fcddb) into master (39de4b2) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 88fcddb differs from pull request most recent head 9f09edc. Consider uploading reports for the commit 9f09edc to get more accurate results

@@            Coverage Diff             @@
##           master   #17581      +/-   ##
==========================================
+ Coverage   73.85%   73.93%   +0.08%     
==========================================
  Files         690      691       +1     
  Lines       91227    91562     +335     
==========================================
+ Hits        67373    67698     +325     
- Misses      22621    22631      +10     
  Partials     1233     1233              
Flag Coverage Δ
python 83.71% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 63.87% <ø> (ø)
.../apache_beam/io/gcp/datastore/v1new/datastoreio.py 86.16% <ø> (ø)
sdks/python/apache_beam/io/gcp/gcsio.py 92.26% <ø> (ø)
sdks/python/apache_beam/io/gcp/pubsub.py 90.65% <ø> (ø)
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 88.23% <100.00%> (ø)
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...s/interactive/dataproc/dataproc_cluster_manager.py 84.21% <0.00%> (-3.70%) ⬇️
sdks/python/apache_beam/coders/row_coder.py 94.49% <0.00%> (-2.65%) ⬇️
sdks/python/apache_beam/runners/common.py 87.94% <0.00%> (-2.33%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 89.20% <0.00%> (-1.64%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39de4b2...9f09edc. Read the comment docs.

@github-actions github-actions bot added the kafka label May 6, 2022
@chamikaramj chamikaramj changed the title [BEAM-14436] Adds code reviewers for GCP I/O connectors to Beam OWNERS files [BEAM-14436] Adds code reviewers for GCP I/O connectors and KafkaIO to Beam OWNERS files May 6, 2022
Copy link
Member

@aaltay aaltay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aaltay
Copy link
Member

aaltay commented May 7, 2022

Run Python PreCommit

@aaltay
Copy link
Member

aaltay commented May 7, 2022

Run Spotless PreCommit

@aaltay
Copy link
Member

aaltay commented May 7, 2022

spotless failure may not be a flake, could you check that and self merge after that?

@chamikaramj
Copy link
Contributor Author

Thanks!

@chamikaramj
Copy link
Contributor Author

Run Spotless PreCommit

@chamikaramj chamikaramj merged commit d13e86b into apache:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants