Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14298] resolve dependency org.pentaho:pentaho-aggdesigner-algorithm:5.1.5-jhyde #17734

Merged
merged 2 commits into from May 24, 2022

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 23, 2022

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 23, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 23, 2022

Can one of the admins verify this patch?

@github-actions github-actions bot added the build label May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #17734 (17c0cf9) into master (1dfab62) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17734      +/-   ##
==========================================
+ Coverage   73.98%   74.00%   +0.01%     
==========================================
  Files         696      696              
  Lines       91851    91851              
==========================================
+ Hits        67958    67972      +14     
+ Misses      22644    22630      -14     
  Partials     1249     1249              
Flag Coverage Δ
python 83.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.09% <0.00%> (+0.15%) ⬆️
...nners/portability/fn_api_runner/worker_handlers.py 79.68% <0.00%> (+0.34%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.68% <0.00%> (+0.37%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 94.02% <0.00%> (+0.74%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 90.64% <0.00%> (+1.43%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️
sdks/python/apache_beam/internal/gcp/auth.py 78.66% <0.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfab62...17c0cf9. Read the comment docs.

@Abacn Abacn marked this pull request as ready for review May 24, 2022 00:58
@Abacn
Copy link
Contributor Author

Abacn commented May 24, 2022

R: @timrobertson100
R: @kennknowles

@Abacn
Copy link
Contributor Author

Abacn commented May 24, 2022

pentaho dependencies are pretty old and has long been removed from maven central. It is a dependency of hive 2.x. Ideally this dep can be removed by updating hive to 3.x (BEAM-9351)

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading would be great as a follow-up.

@lukecwik lukecwik merged commit 94b6190 into apache:master May 24, 2022
@Abacn Abacn deleted the pentahodep branch May 25, 2022 00:23
ahmedabu98 added a commit to ahmedabu98/beam that referenced this pull request Jul 14, 2022
suztomo pushed a commit to suztomo/beam that referenced this pull request Sep 26, 2022
…ithm:5.1.5-jhyde (apache#17734)

* [BEAM-14298] resolve dependency org.pentaho:pentaho-aggdesigner-algorithm:5.1.5-jhyde

* change search priority to avoid firewalled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants