New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14298] resolve dependency org.pentaho:pentaho-aggdesigner-algorithm:5.1.5-jhyde #17734
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17734 +/- ##
==========================================
+ Coverage 73.98% 74.00% +0.01%
==========================================
Files 696 696
Lines 91851 91851
==========================================
+ Hits 67958 67972 +14
+ Misses 22644 22630 -14
Partials 1249 1249
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
R: @timrobertson100 |
pentaho dependencies are pretty old and has long been removed from maven central. It is a dependency of hive 2.x. Ideally this dep can be removed by updating hive to 3.x (BEAM-9351) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading would be great as a follow-up.
…ithm:5.1.5-jhyde (apache#17734) * [BEAM-14298] resolve dependency org.pentaho:pentaho-aggdesigner-algorithm:5.1.5-jhyde * change search priority to avoid firewalled
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.