[BEAM-980] Support configuration of Apex DAG through properties file. #1850
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
| * The runner will look for this file in the classpath for Apex configuration properties | ||
| * unless an alternative location was specified in pipeline options. | ||
| */ | ||
| public static final String RUNNER_PROPERTIES_RESOURCE = "/beam-runners-apex.properties"; |
There was a problem hiding this comment.
Any reason it isn't a @Default on the pipeline option?
There was a problem hiding this comment.
Yes, wanted to do that also, would be better from a documentation perspective. But a value starting with '/' is interpreted as local file path, while the default is a classpath resource. Any idea how to handle that?
There was a problem hiding this comment.
Updated with explicit URL scheme for classpath and made the default visible through the options.
|
Refer to this link for build results (access rights to CI server needed): |
|
@kennknowles is the PR good to merge? |
|
Yes! |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @kennknowles