Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1392] DoFn teardown not called on empty partitions #1920

Closed

Conversation

aviemzur
Copy link
Member

@aviemzur aviemzur commented Feb 5, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@aviemzur
Copy link
Member Author

aviemzur commented Feb 5, 2017

R: @amitsela

@amitsela
Copy link
Member

amitsela commented Feb 5, 2017

LGTM.

@asfgit asfgit closed this in e5afbb2 Feb 5, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 69.691% when pulling cf1ea05 on aviemzur:invoke-teardown-on-empty-partition into 6e220bb on apache:master.

@asfbot
Copy link

asfbot commented Feb 5, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7087/
--none--

@dhalperi
Copy link
Contributor

dhalperi commented Feb 5, 2017

Driveby: nice catch!

@amitsela
Copy link
Member

amitsela commented Feb 5, 2017

Yeah.. we had a nasty "too many open files" when running against sparse topics..

@aviemzur aviemzur deleted the invoke-teardown-on-empty-partition branch March 11, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants