Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1392] DoFn teardown not called on empty partitions #1920

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ Iterable<OutputT> processPartition(

// skip if partition is empty.
if (!partition.hasNext()) {
DoFnInvokers.invokerFor(doFn).invokeTeardown();
return Lists.newArrayList();
}

// call startBundle() before beginning to process the partition.
doFnRunner.startBundle();
// process the partition; finishBundle() is called from within the output iterator.
Expand Down