Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-646] Use Surgery in the Dataflow Runner #2039

Closed
wants to merge 3 commits into from

Conversation

tgroh
Copy link
Member

@tgroh tgroh commented Feb 17, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Couple of cleanups and underlying PRs still have to be submitted prior to actual review.

I do want to use this PR to run some RunnableOnService Tests, though.

@tgroh
Copy link
Member Author

tgroh commented Feb 17, 2017

Run Dataflow RunnableOnService

@asfbot
Copy link

asfbot commented Feb 17, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7564/

Build result: FAILURE

[...truncated 4596 lines...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:332) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoFailureException: You have 2 Checkstyle violations. at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:588) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-02-17T23:12:21.425 [ERROR] 2017-02-17T23:12:21.425 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-17T23:12:21.425 [ERROR] 2017-02-17T23:12:21.425 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-17T23:12:21.425 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-02-17T23:12:21.426 [ERROR] 2017-02-17T23:12:21.426 [ERROR] After correcting the problems, you can resume the build with the command2017-02-17T23:12:21.426 [ERROR] mvn -rf :beam-runners-direct-javachannel stoppedSetting status of 46d6b1e to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7564/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 68.911% when pulling 580243e on tgroh:dataflow_runner_surgery into 9335738 on apache:master.

@asfbot
Copy link

asfbot commented Feb 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2328/

Failed Tests: 116

beam_PostCommit_Java_RunnableOnService_Dataflow/org.apache.beam:beam-runners-google-cloud-dataflow-java: 116


--none--

@tgroh tgroh force-pushed the dataflow_runner_surgery branch 2 times, most recently from 96beeb7 to b9742ca Compare February 18, 2017 01:08
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 68.886% when pulling b9742ca on tgroh:dataflow_runner_surgery into 918c7fa on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 68.879% when pulling b9742ca on tgroh:dataflow_runner_surgery into 918c7fa on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 68.877% when pulling 1229c97 on tgroh:dataflow_runner_surgery into 918c7fa on apache:master.

@asfbot
Copy link

asfbot commented Feb 21, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7634/

Build result: FAILURE

[...truncated 620.03 KB...] at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoFailureException: You have 1 Checkstyle violation. at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:588) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-02-21T18:20:18.663 [ERROR] 2017-02-21T18:20:18.663 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-21T18:20:18.663 [ERROR] 2017-02-21T18:20:18.663 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-21T18:20:18.663 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-02-21T18:20:18.663 [ERROR] 2017-02-21T18:20:18.663 [ERROR] After correcting the problems, you can resume the build with the command2017-02-21T18:20:18.663 [ERROR] mvn -rf :beam-runners-google-cloud-dataflow-javachannel stoppedSetting status of 5c56e8a to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7634/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 68.945% when pulling 09e2278 on tgroh:dataflow_runner_surgery into eb59a1d on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.07% when pulling 777ea60 on tgroh:dataflow_runner_surgery into 154c543 on apache:master.

@tgroh
Copy link
Member Author

tgroh commented Feb 21, 2017

Run Dataflow RunnableOnService

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.061% when pulling 1af755f on tgroh:dataflow_runner_surgery into 2982238 on apache:master.

@asfbot
Copy link

asfbot commented Feb 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7661/
--none--

@asfbot
Copy link

asfbot commented Feb 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2362/

Build result: FAILURE

[...truncated 1.11 MB...] at org.apache.rat.analysis.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:46) at org.apache.rat.analysis.DefaultAnalyserFactory$DefaultAnalyser.analyse(DefaultAnalyserFactory.java:60) at org.apache.rat.document.impl.util.DocumentAnalyserMultiplexer.analyse(DocumentAnalyserMultiplexer.java:36) at org.apache.rat.report.claim.util.ClaimReporterMultiplexer.report(ClaimReporterMultiplexer.java:42) ... 39 moreCaused by: java.io.FileNotFoundException: src/test/java/org/apache/beam/sdk/TestUtils.java (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at org.apache.rat.mp.FilesReportable$FileDocument.reader(FilesReportable.java:88) at org.apache.rat.analysis.DocumentHeaderAnalyser.analyse(DocumentHeaderAnalyser.java:41) ... 42 more2017-02-22T01:01:42.800 [ERROR] 2017-02-22T01:01:42.801 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-22T01:01:42.801 [ERROR] 2017-02-22T01:01:42.801 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-22T01:01:42.801 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-02-22T01:01:42.801 [ERROR] 2017-02-22T01:01:42.801 [ERROR] After correcting the problems, you can resume the build with the command2017-02-22T01:01:42.801 [ERROR] mvn -rf :beam-sdks-java-corechannel stoppedSending e-mails to: commits@beam.apache.org jbonofre@apache.org tgroh@google.com klk@google.com altay@google.comSetting status of 1af755f to FAILURE with url https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2362/ and message: 'Build finished. 'Using context: Jenkins: Google Cloud Dataflow Runner RunnableOnService Tests
--none--

@tgroh
Copy link
Member Author

tgroh commented Feb 22, 2017

Run Dataflow RunnableOnService

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.076% when pulling df83ec3 on tgroh:dataflow_runner_surgery into fbaac0f on apache:master.

@asfbot
Copy link

asfbot commented Feb 22, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7705/
--none--

@kennknowles
Copy link
Member

Code looks good, but I want to see what happens between now and green ROS. There's a possibility you'll need a new worker image.

@tgroh
Copy link
Member Author

tgroh commented Feb 23, 2017

Run Dataflow RunnableOnService

@asfbot
Copy link

asfbot commented Feb 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7733/

Build result: FAILURE

[...truncated 543.18 KB...] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/runners/core-java/src/main/java/org/apache/beam/runners/core/SideInputHandler.java:[119,58] cannot find symbol symbol: method getCoderInternal() location: variable sideInput of type org.apache.beam.sdk.values.PCollectionView<?> at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1029) at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:137) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-02-23T02:47:43.842 [ERROR] 2017-02-23T02:47:43.842 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-23T02:47:43.842 [ERROR] 2017-02-23T02:47:43.842 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-23T02:47:43.842 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-02-23T02:47:43.842 [ERROR] 2017-02-23T02:47:43.842 [ERROR] After correcting the problems, you can resume the build with the command2017-02-23T02:47:43.842 [ERROR] mvn -rf :beam-runners-core-javachannel stoppedSetting status of ec18c91 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7733/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@asfbot
Copy link

asfbot commented Feb 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2383/

Failed Tests: 151

beam_PostCommit_Java_RunnableOnService_Dataflow/org.apache.beam:beam-runners-google-cloud-dataflow-java: 151


--none--

@tgroh
Copy link
Member Author

tgroh commented Feb 23, 2017

Run Dataflow RunnableOnService

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 69.084% when pulling 15e3c17 on tgroh:dataflow_runner_surgery into 3a8ae53 on apache:master.

@asfbot
Copy link

asfbot commented Feb 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7782/
--none--

@asfbot
Copy link

asfbot commented Feb 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2392/
--none--

@tgroh
Copy link
Member Author

tgroh commented Feb 24, 2017

@kennknowles PTAL (Dataflow ROS is green, woop woop)

@@ -440,6 +441,7 @@ public void testDiskSizeGbConfig() throws IOException {
}

@Test
@Ignore("TODO: Reenable when the hierarchy is copied")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each TODO: I think some are fixed, some should be just deleted, and the rest should have JIRAs if possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All are fixed, with exposure of performSurgery

@kennknowles
Copy link
Member

LGTM pending changes just to @Ignore unit tests, which shouldn't materially change this PR.

@asfbot
Copy link

asfbot commented Feb 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7824/

Build result: ABORTED

[...truncated 792.59 KB...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/hbase && /usr/local/asfpackages/java/jdk1.8.0_121/jre/bin/java org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/hbase/target/surefire/surefire5316712535186464581tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall/sdks/java/io/hbase/target/surefire/surefire_81718212360316678872tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-02-24T21:13:58.618 [ERROR] 2017-02-24T21:13:58.618 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-24T21:13:58.618 [ERROR] 2017-02-24T21:13:58.619 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-24T21:13:58.619 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-02-24T21:13:58.619 [ERROR] 2017-02-24T21:13:58.619 [ERROR] After correcting the problems, you can resume the build with the command2017-02-24T21:13:58.619 [ERROR] mvn -rf :beam-sdks-java-io-hbaseBuild was abortedchannel stoppedSetting status of 2165852 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7824/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@asfbot
Copy link

asfbot commented Feb 24, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7826/

Build result: ABORTED

[...truncated 793.34 KB...] ... 31 moreCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/io/hbase && /usr/local/asfpackages/java/jdk1.8.0_121/jre/bin/java org.apache.maven.surefire.booter.ForkedBooter /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/io/hbase/target/surefire/surefire8763274207289909236tmp /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/sdks/java/io/hbase/target/surefire/surefire_8682168825656325026tmp at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229) at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862) at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) ... 32 more2017-02-24T21:45:16.870 [ERROR] 2017-02-24T21:45:16.870 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-02-24T21:45:16.870 [ERROR] 2017-02-24T21:45:16.870 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-02-24T21:45:16.870 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException2017-02-24T21:45:16.871 [ERROR] 2017-02-24T21:45:16.871 [ERROR] After correcting the problems, you can resume the build with the command2017-02-24T21:45:16.871 [ERROR] mvn -rf :beam-sdks-java-io-hbaseBuild was abortedchannel stoppedSetting status of d200b38 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7826/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

Use Pipeline Surgery in the Dataflow Runner

Add additional override factories for Dataflow overrides.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3b0c64d on tgroh:dataflow_runner_surgery into ** on apache:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 62e02c0 on tgroh:dataflow_runner_surgery into ** on apache:master**.

@kennknowles
Copy link
Member

Run Dataflow RunnableOnService

@asfbot
Copy link

asfbot commented Feb 25, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7855/
--none--

@asfbot
Copy link

asfbot commented Feb 25, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Dataflow/2404/
--none--

@asfgit asfgit closed this in aaf0884 Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants