Update references to Jira to GH for the Python SDK #21831
Conversation
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| requires_partition_by = partitionings.Singleton( | ||
| reason=( | ||
| f"reset_index(level={level!r}) drops the entire index and " | ||
| "creates a new one, so it cannot currently be parallelized " | ||
| "(BEAM-12182).")) | ||
| "(Issue 20859).")) |
There was a problem hiding this comment.
I think a URL would be preferable in error messages for easy discovery. Previously BEAM-12182 could likely be found with a Google search, but "20859" will require the user to construct the URL.
There was a problem hiding this comment.
I ended up just moving everything to URLs. I think the same logic applies more generally than just in error messages.
Codecov Report
@@ Coverage Diff @@
## master #21831 +/- ##
==========================================
- Coverage 74.15% 74.13% -0.03%
==========================================
Files 698 698
Lines 92417 92436 +19
==========================================
- Hits 68530 68525 -5
- Misses 22636 22660 +24
Partials 1251 1251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Note you can run |
Oh, just seeing this - well I guess I did it the hard way 🤷 |
|
R: @TheNeuralBit - I think this should be ready! |
* Update references to Jira to GH for the Python SDK * Fix a few breakages * One more fix * line length linting * Fix string * A few more replacements * Use links instead of Issue # * Formatting * Formatting * Formatting * Formatting * Formatting * Formatting * Extraneous space * One more long line
Part of #21812
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.