Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch go todos from issue # syntax to links #21890

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

damccorm
Copy link
Contributor

In #21830 I updated all our Go TODOs to reference issues as TODO(Issue #), but in #21831 Brian convinced me that links are better. This updates to use links.

Part of #21812


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

2 similar comments
@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

@asf-ci
Copy link

asf-ci commented Jun 15, 2022

Can one of the admins verify this patch?

@damccorm
Copy link
Contributor Author

R: @riteshghorse and @lostluck - tagging you directly for continuity (should be an easy one)

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #21890 (60ad46e) into master (9a74f17) will not change coverage.
The diff coverage is 70.58%.

@@           Coverage Diff           @@
##           master   #21890   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         699      699           
  Lines       92675    92675           
=======================================
  Hits        68592    68592           
  Misses      22828    22828           
  Partials     1255     1255           
Flag Coverage Δ
go 50.82% <70.58%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/artifact/materialize.go 43.50% <ø> (ø)
sdks/go/pkg/beam/core/graph/coder/coder.go 85.98% <ø> (ø)
sdks/go/pkg/beam/core/graph/mtime/time.go 68.42% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/cogbk.go 0.00% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/combine.go 60.43% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/translate.go 14.28% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/graphx/cogbk.go 72.72% <ø> (ø)
...dks/go/pkg/beam/core/runtime/harness/monitoring.go 23.12% <ø> (ø)
sdks/go/pkg/beam/core/util/jsonx/jsonx.go 78.57% <ø> (ø)
sdks/go/pkg/beam/io/textio/textio.go 55.15% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a74f17...60ad46e. Read the comment docs.

@riteshghorse
Copy link
Contributor

LGTM! It's the same license one that's failing

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@lostluck lostluck merged commit 6bffe84 into apache:master Jun 15, 2022
@damccorm damccorm deleted the users/damccorm/goStrings branch June 15, 2022 17:57
bullet03 pushed a commit to akvelon/beam that referenced this pull request Jun 20, 2022
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants