Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1645] Populate display data on Window.Assign #2185

Closed
wants to merge 1 commit into from

Conversation

kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Do not review yet; running through Jenkins while checking other things.

@kennknowles
Copy link
Member Author

It is actually much better to keep the diff behavior we have now. We can just reify the diff, and we have uses for that elsewhere too.

@kennknowles kennknowles closed this Mar 7, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 70.055% when pulling b716615 on kennknowles:Assign-DisplayData into 4c3fce1 on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants