[BEAM-1645] Populate display data on Window.Assign #2189
Conversation
|
@tgroh @bjchambers I haven't actually run this yet and looked at the UI, but you might be interested. |
| } | ||
| populateWindowingStrategyDisplayData( | ||
| WindowingStrategy.of(windowFn) | ||
| .withAllowedLateness(allowedLateness) |
There was a problem hiding this comment.
Here I need to build the windowing strategy conditionally.
There was a problem hiding this comment.
I feel as though allowing a null WindowFn should not be permitted by WindowingStrategy, as an aside.
There was a problem hiding this comment.
We do lack the context here to construct the entire windowing strategy, which is unfortunate. Window.Assign is provided it on construction, but I don't know if there's any way to pass it to the identity flatten's display data.
| private static void populateWindowingStrategyDisplayData( | ||
| WindowingStrategy<?, ?> windowingStrategy, DisplayData.Builder builder) { | ||
|
|
||
| builder |
There was a problem hiding this comment.
The windowFn and closing behavior are not conditionalized the same way. Cleaner would be to explicitly represent a diff vs a completed strategy.
There was a problem hiding this comment.
This looks like mostly the right approach. It may have to be that we have the "populate with the following n fields" instead of having a smarter thing that populates from the entire WindowingStrategy, just by virtue of the lack of entire symmetry with "isWindowFnSpecified"
| } | ||
| populateWindowingStrategyDisplayData( | ||
| WindowingStrategy.of(windowFn) | ||
| .withAllowedLateness(allowedLateness) |
There was a problem hiding this comment.
I feel as though allowing a null WindowFn should not be permitted by WindowingStrategy, as an aside.
| } | ||
| populateWindowingStrategyDisplayData( | ||
| WindowingStrategy.of(windowFn) | ||
| .withAllowedLateness(allowedLateness) |
There was a problem hiding this comment.
We do lack the context here to construct the entire windowing strategy, which is unfortunate. Window.Assign is provided it on construction, but I don't know if there's any way to pass it to the identity flatten's display data.
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 726.57 KB...] ^/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachine.java:198: error: reference not found * Removes the timer set in this trigger context for the given {@link Instant} ^Command line was: /usr/local/asfpackages/java/jdk1.8.0_121/jre/../bin/javadoc @options @packagesRefer to the generated Javadoc files in '/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_MavenInstall@2/runners/core-java/target/apidocs' dir. at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.executeJavadocCommandLine(AbstractJavadocMojo.java:5188) at org.apache.maven.plugin.javadoc.AbstractJavadocMojo.executeReport(AbstractJavadocMojo.java:2075) at org.apache.maven.plugin.javadoc.JavadocJar.execute(JavadocJar.java:188) ... 33 more2017-03-08T00:48:59.226 [ERROR] 2017-03-08T00:48:59.226 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-08T00:48:59.227 [ERROR] 2017-03-08T00:48:59.227 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-08T00:48:59.227 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-03-08T00:48:59.227 [ERROR] 2017-03-08T00:48:59.227 [ERROR] After correcting the problems, you can resume the build with the command2017-03-08T00:48:59.227 [ERROR] mvn -rf :beam-runners-core-javachannel stoppedSetting status of b3c979f to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8188/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
|
This is probably preempted by #2258 |
|
@kennknowles is this still worthwhile? |
|
I was going to ask you the same thing. I think it was addressed adequately while I was away. |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.