Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][release-2.40.0] Merge pull request #21895: Drops usage of setWindowingStrategyInterna… #21914

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Jun 16, 2022

…l in favour of direct use of WindowFn

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member Author

pabloem commented Jun 16, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 16, 2022

r: @kennknowles

Copy link
Member

@egalpin egalpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CP! 🚢

@pabloem pabloem closed this Jun 16, 2022
@pabloem pabloem reopened this Jun 16, 2022
@pabloem
Copy link
Member Author

pabloem commented Jun 16, 2022

Run Java PostCommit

@pabloem
Copy link
Member Author

pabloem commented Jun 17, 2022

Run Java PreCommit

@pabloem pabloem merged commit f78453f into apache:release-2.40.0 Jun 17, 2022
@pabloem pabloem deleted the es-fixup-cpik branch June 17, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants