Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground] Remove Beam Summit banner from Playground #22410

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

miamihotline
Copy link
Contributor

Removed Beam Summit banner from Playground header, deleted unused assets.

Fixes #22364

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem LGTM

@pabloem pabloem merged commit 97a90f0 into apache:master Aug 8, 2022
@pabloem
Copy link
Member

pabloem commented Aug 8, 2022

thanks y'\all lgtm

@brucearctor
Copy link
Contributor

@pabloem --> Did this also address: #22424 ? Looks like that is no longer something that needs to be done, but trying to understand the code change that addressed it? If not this, can someone point me to the relevant issue to tag/close that issue ( to be able to easily restore in the future )?

@brucearctor
Copy link
Contributor

@miamihotline -- did this code also address #22424 ? @damondouglas ( since approved ) maybe you have an idea?

Otherwise, wanting to track down how that got 'fixed' if not this issue. Please advise either way.

@olehborysevych
Copy link
Collaborator

@alexeyinkin could you please address comments above

@alexeyinkin
Copy link
Contributor

The website banner was removed in 33dc35f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove Beam Summit banner from Playground
6 participants