Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1839] Added a specific signature so that Kryo doesn't have to look for it. #2357

Closed
wants to merge 3 commits into from
Closed

[BEAM-1839] Added a specific signature so that Kryo doesn't have to look for it. #2357

wants to merge 3 commits into from

Conversation

staslev
Copy link
Contributor

@staslev staslev commented Mar 29, 2017

…sing reflective exploration.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@staslev
Copy link
Contributor Author

staslev commented Mar 29, 2017

R: @aviemzur

@staslev
Copy link
Contributor Author

staslev commented Mar 29, 2017

This change aims to optimize this Kryo flow.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 70.173% when pulling d236684 on staslev:optimised-StatelessJavaSerializer into 99056df on apache:master.

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8891/

Build result: FAILURE

[...truncated 1.25 MB...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoFailureException: You have 1 Checkstyle violation. at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:588) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-29T13:50:50.649 [ERROR] 2017-03-29T13:50:50.649 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-29T13:50:50.649 [ERROR] 2017-03-29T13:50:50.649 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-29T13:50:50.649 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-03-29T13:50:50.649 [ERROR] 2017-03-29T13:50:50.649 [ERROR] After correcting the problems, you can resume the build with the command2017-03-29T13:50:50.649 [ERROR] mvn -rf :beam-runners-sparkchannel stoppedSetting status of d236684 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8891/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8888/
--none--

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.16% when pulling 0f1776f on staslev:optimised-StatelessJavaSerializer into 99056df on apache:master.

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8895/
--none--

@aviemzur
Copy link
Member

Run Spark ValidatesRunner

@aviemzur
Copy link
Member

LGTM pending ValidatesRunner tests.

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/1432/
--none--

@staslev staslev changed the title Added a specific signature so that Kryo doesn't have to look for it u… [BEAM-1839] Added a specific signature so that Kryo doesn't have to look for it. Mar 30, 2017
@asfgit asfgit closed this in 22d368b Mar 30, 2017
@staslev staslev deleted the optimised-StatelessJavaSerializer branch March 30, 2017 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants