-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade checkerframework to 3.13.0 #24385
Conversation
This version of checker framework shortened many warning suppression keys. For atomicity, those key changes are included in this commit.
Codecov Report
@@ Coverage Diff @@
## master #24385 +/- ##
==========================================
+ Coverage 73.34% 73.36% +0.01%
==========================================
Files 718 718
Lines 97034 97033 -1
==========================================
+ Hits 71172 71186 +14
+ Misses 24531 24516 -15
Partials 1331 1331
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @kileys for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Java PreCommit |
Run Java_Kafka_IO_Direct PreCommit |
https://ci-beam.apache.org/job/beam_PreCommit_Java_Kafka_IO_Direct_Commit/610/ we see actually broken test assertions (obviously cannot be related to this PR). https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/25032/ seems to have a gradle cache lock problem. |
This particular upgrade involves a number of changes to type checking suppression keys, so it is helpful to do it separate from further upgrades I think.
Note that I've included a minor commit in the same PR that should be kept separate as it is just a fix to the gradle scripts.
A step towards:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.