Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade checkerframework to 3.13.0 #24385

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

kennknowles
Copy link
Member

@kennknowles kennknowles commented Nov 28, 2022

This particular upgrade involves a number of changes to type checking suppression keys, so it is helpful to do it separate from further upgrades I think.

Note that I've included a minor commit in the same PR that should be kept separate as it is just a fix to the gradle scripts.

A step towards:


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

This version of checker framework shortened many warning suppression keys. For
atomicity, those key changes are included in this commit.
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #24385 (596e19f) into master (a493cc1) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24385      +/-   ##
==========================================
+ Coverage   73.34%   73.36%   +0.01%     
==========================================
  Files         718      718              
  Lines       97034    97033       -1     
==========================================
+ Hits        71172    71186      +14     
+ Misses      24531    24516      -15     
  Partials     1331     1331              
Flag Coverage Δ
python 83.00% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/transforms/core.py 92.90% <0.00%> (+0.36%) ⬆️
...eam/runners/portability/fn_api_runner/execution.py 93.13% <0.00%> (+0.63%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 91.77% <0.00%> (+1.26%) ⬆️
.../python/apache_beam/transforms/periodicsequence.py 98.50% <0.00%> (+1.49%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 92.85% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kileys for label java.
R: @damccorm for label build.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles
Copy link
Member Author

Run Java_Kafka_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

https://ci-beam.apache.org/job/beam_PreCommit_Java_Kafka_IO_Direct_Commit/610/ we see actually broken test assertions (obviously cannot be related to this PR).

https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/25032/ seems to have a gradle cache lock problem.

@kennknowles kennknowles merged commit 596e19f into apache:master Nov 30, 2022
@kennknowles kennknowles deleted the checker-3.13.0 branch November 30, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant