Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract BundleManager to an Interface in SamzaRunner #26268

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

ryucc
Copy link
Contributor

@ryucc ryucc commented Apr 13, 2023

Making BundleManager an interface, so we can have a Portable version later.

  • Moved original class to ClassicBundleManager
  • Updated unit tests.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@ryucc ryucc changed the title Interface BundleManager Extract BundleManager to an Interface in SamzaRunner Apr 13, 2023
Copy link
Contributor

@xinyuiscool xinyuiscool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the refactoring.

@xinyuiscool xinyuiscool merged commit 5a9ab68 into apache:master Apr 13, 2023
10 checks passed
@ryucc ryucc deleted the interface-bundle-manager branch April 20, 2023 22:39
jakubrauch pushed a commit to jakubrauch/beam that referenced this pull request Apr 27, 2023
ryucc added a commit to linkedin/beam that referenced this pull request May 11, 2023
rezarokni pushed a commit to rezarokni/beam that referenced this pull request May 22, 2023
ryucc added a commit to linkedin/beam that referenced this pull request May 31, 2023
Extract BundleManager to an Interface in SamzaRunner (apache#26268)

Refactor DoFnOp.FutureCollectorImpl to a top level class in SamzaRunner (apache#26274)

Add JavaDoc to BundleManager in Samza Runner (apache#26287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants