Refactor DoFnOp.FutureCollectorImpl to a top level class in SamzaRunner #26274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too general a statement. I don't think nested classes are anti-pattern. I see the motivation here is multi-fold but wouldn't treat/callout this as a motivation as this gives out incorrect signal on usage of nested class. |
mynameborat
approved these changes
Apr 13, 2023
jakubrauch
pushed a commit
to jakubrauch/beam
that referenced
this pull request
Apr 27, 2023
rezarokni
pushed a commit
to rezarokni/beam
that referenced
this pull request
May 22, 2023
ryucc
added a commit
to linkedin/beam
that referenced
this pull request
May 31, 2023
Extract BundleManager to an Interface in SamzaRunner (apache#26268) Refactor DoFnOp.FutureCollectorImpl to a top level class in SamzaRunner (apache#26274) Add JavaDoc to BundleManager in Samza Runner (apache#26287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making FutureCollectorImpl a top level class for the following reasons
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.